From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8BB7C4742C for ; Mon, 2 Nov 2020 14:56:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6CA632231B for ; Mon, 2 Nov 2020 14:56:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="1vhVi/TI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CA632231B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D4BE56B005D; Mon, 2 Nov 2020 09:56:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CFAA56B006C; Mon, 2 Nov 2020 09:56:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C13206B006E; Mon, 2 Nov 2020 09:56:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id 953B16B005D for ; Mon, 2 Nov 2020 09:56:47 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 34B013499 for ; Mon, 2 Nov 2020 14:56:47 +0000 (UTC) X-FDA: 77439780054.11.hill75_22062fa272b0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 095F8180F8B80 for ; Mon, 2 Nov 2020 14:56:47 +0000 (UTC) X-HE-Tag: hill75_22062fa272b0 X-Filterd-Recvd-Size: 4602 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 14:56:46 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id j31so2614991qtb.8 for ; Mon, 02 Nov 2020 06:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=y0YbMA6MgS0VVP9wIqs606A+W5kzypLLo2uJ5yzWsp8=; b=1vhVi/TIRF7BDl6cNAGmMWQ9H4M2phsWWXLUY+8VngGCC6WkJ7vRPZNIkcIgeJ9jvM 5tTwdWw/u00Bk92JyiLPxRLPS2Rt05dwhH2rAyGgzzzazKkXKAU+3yy37KckDYxXvGu3 GZhiVeifeLhbd4cl833PsnioynbYERlWVuXrFXIBcgd2bpsFgWSNHUeP+a2aaWmIwBsM OHdTBVX/zEtZSuKU+cbInOiTtXvGRVLhUq7WMVe5cyjM54irjsvZPQsyw9JOpj72PPTK +QF/D3nTqK0nO8uQF4mXTohlgqWuEJTJWWhtVyeDiMRXtO9fo0k+jSoDtfkZldv0xd0I wJ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y0YbMA6MgS0VVP9wIqs606A+W5kzypLLo2uJ5yzWsp8=; b=H1XGjRaHZriZ0P0+adQ9qbjAKrbMd45SBleMM29+awiJ3h64Fn9LWORWC3VIAJqQsT 9on57B+0heaIaR47cGHXyoY2qnYoywebi+iw9rMRe4RywGloxaO8N3Mh659kn9puk+6c U+te48QhKdWUGIL8OQI1Tb2k2S25Wx1TAR5GO38Gyd3YxsvFhReALXjmaoFRDfYZVyAD rlK2upefnKKNvgVrjIwMAYRGpYlMaT4PWdhspghE33zbq7VO34SOZFlijncykS/jh3Wv Jis7WNxxJCjTNqEo9qk5iBz4A57X4OsH5YmZBfVxkHWB7Mhxi/RM10oTunu2fH1IViGU pg7A== X-Gm-Message-State: AOAM532pRDqDi4DXRVjE0rWtYmSfoA7ByMizelA/iHQbWK4/ey+f7B4L UESlaS1ZaASp/wS+p7MX63JNzQ== X-Google-Smtp-Source: ABdhPJw1ZdW/lqa6VECafrpbgJu7XEH+T2QMW3IofuNFTjhThZ39B/uFy2H2Ojo6YrZGmoX+m11GQg== X-Received: by 2002:ac8:5909:: with SMTP id 9mr4991633qty.382.1604329005744; Mon, 02 Nov 2020 06:56:45 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:2f6e]) by smtp.gmail.com with ESMTPSA id k64sm8183844qkc.97.2020.11.02.06.56.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:56:45 -0800 (PST) Date: Mon, 2 Nov 2020 09:55:00 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, "Kirill A. Shutemov" , Vlastimil Babka Subject: Re: [PATCH v20 13/20] mm/mlock: remove lru_lock on TestClearPageMlocked Message-ID: <20201102145500.GF724984@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-14-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-14-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 06:44:58PM +0800, Alex Shi wrote: > In the func munlock_vma_page, comments mentained lru_lock needed for > serialization with split_huge_pages. But the page must be PageLocked > as well as pages in split_huge_page series funcs. Thus the PageLocked > is enough to serialize both funcs. > > Further more, Hugh Dickins pointed: before splitting in > split_huge_page_to_list, the page was unmap_page() to remove pmd/ptes > which protect the page from munlock. Thus, no needs to guard > __split_huge_page_tail for mlock clean, just keep the lru_lock there for > isolation purpose. > > LKP found a preempt issue on __mod_zone_page_state which need change > to mod_zone_page_state. Thanks! > > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Cc: Kirill A. Shutemov > Cc: Vlastimil Babka > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Acked-by: Johannes Weiner