From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C558C4742C for ; Mon, 2 Nov 2020 14:54:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A13562227F for ; Mon, 2 Nov 2020 14:54:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="pg3oYsVQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A13562227F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F26BD6B0073; Mon, 2 Nov 2020 09:54:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED66C6B0074; Mon, 2 Nov 2020 09:54:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEC4B6B0075; Mon, 2 Nov 2020 09:54:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id B17AE6B0073 for ; Mon, 2 Nov 2020 09:54:08 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5DA92180AD806 for ; Mon, 2 Nov 2020 14:54:08 +0000 (UTC) X-FDA: 77439773376.13.boot30_5817cf4272b0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 3671118140B67 for ; Mon, 2 Nov 2020 14:54:08 +0000 (UTC) X-HE-Tag: boot30_5817cf4272b0 X-Filterd-Recvd-Size: 4441 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 14:54:07 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id a64so8289305qkc.5 for ; Mon, 02 Nov 2020 06:54:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FF/JppJfxHL8ahJoJtPZ+p8h36QJk45Xb6vKWkqMYyw=; b=pg3oYsVQCcy7LuZa9ij1hYP+NbXJnYUJYqvAiWBgxzUX7RYZON9zygT2ZPp6F8QjqX ZebaplFHW2oBtkjQ7lAA0p4x7MxBLaBsmDqG7pXCTtCa1Wes9WpirKmT1NL69OmApInp +nt4h1EqBS7BIwpV1nZ5DpIkLmuDQP3XKHETORH2zXtib3kHz76R/hAXEQ1VZcCo9uJu 7i8M0Kkhiu9bUVGyDP/6zSlARAhN3+BBVYtV/9a6rjBlj3DC/Dk6AbsZ6LHoCiWp1KsE PRxGR0eduA8DXKx3CILnmoNBdmyCJy22nLpB7SxGCF6Y8UIdrItHGqNZvXoHjy3BTn7H SpIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FF/JppJfxHL8ahJoJtPZ+p8h36QJk45Xb6vKWkqMYyw=; b=UCXWK8V3o7Im3wV6EtflYdf8pYjv6xvtXsqNWNT4SenTNdHm7RaRlL0W3DnRDFaxTH hjJQKvlTtJxlqaVnVsu+4DU2H5StYpColxcltt3YIw7Ing6emzgllPESl9vZcDZ9I9Hd lAabxZOO2E3fgiZWwX5TfptgU93ZtXm5qftVGJ0vXS3pU1Hf+Yg/shgmfbhYwUhOg825 7ffcNU5cJ3n6357rtPZI9LXnQHOUEUDBEzl7M5X+GAIddOid4fRbT/eZxOr5NPsqTVQQ gQ44XnKR2Ps0LlZeKTV++WAv2kxhfr/FlzRnzC7puZVAKsE+/m77RHR6JIEhwRF/Vwxc UWcw== X-Gm-Message-State: AOAM530kCxCigNXIWkOHC30NxRcpiawwzl3i71aixi4WXDpG1a7Y23i8 kHmPNYMGGqVd+p2SEgmiNo/1+g== X-Google-Smtp-Source: ABdhPJzVl4fH3qjWKemLmU0HXb0wx7FNPKcWuNz2M0gD0VEI3nqrp45sniYdi3oRbTSM12OlI88x+w== X-Received: by 2002:a37:e51:: with SMTP id 78mr15099002qko.191.1604328846819; Mon, 02 Nov 2020 06:54:06 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:2f6e]) by smtp.gmail.com with ESMTPSA id z69sm8211620qkb.7.2020.11.02.06.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:54:05 -0800 (PST) Date: Mon, 2 Nov 2020 09:52:20 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Alexander Duyck , Michal Hocko Subject: Re: [PATCH v20 12/20] mm/vmscan: remove lruvec reget in move_pages_to_lru Message-ID: <20201102145220.GE724984@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-13-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-13-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 06:44:57PM +0800, Alex Shi wrote: > A isolated page shouldn't be recharged by memcg since the memcg > migration isn't possible at the time. > So remove unnecessary regetting. > > Thanks to Alexander Duyck for pointing this out. > > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Cc: Alexander Duyck > Cc: Andrew Morton > Cc: Konstantin Khlebnikov > Cc: Michal Hocko > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: cgroups@vger.kernel.org Acked-by: Johannes Weiner A brief comment in the code could be good: all pages were isolated from the same lruvec (and isolation inhibits memcg migration).