From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18194C4742C for ; Mon, 2 Nov 2020 14:50:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 659D321D91 for ; Mon, 2 Nov 2020 14:50:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="H5HLQwnJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 659D321D91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D0CB06B0073; Mon, 2 Nov 2020 09:50:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CBD1C6B0074; Mon, 2 Nov 2020 09:50:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD3B66B0075; Mon, 2 Nov 2020 09:50:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 916796B0073 for ; Mon, 2 Nov 2020 09:50:26 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2869D180AD807 for ; Mon, 2 Nov 2020 14:50:26 +0000 (UTC) X-FDA: 77439764052.17.start01_2207a0e272b0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 0689A180D0184 for ; Mon, 2 Nov 2020 14:50:26 +0000 (UTC) X-HE-Tag: start01_2207a0e272b0 X-Filterd-Recvd-Size: 4148 Received: from mail-qv1-f66.google.com (mail-qv1-f66.google.com [209.85.219.66]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 14:50:25 +0000 (UTC) Received: by mail-qv1-f66.google.com with SMTP id bl9so6183847qvb.10 for ; Mon, 02 Nov 2020 06:50:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JYqsaLDo1+ctYQbIf4q0wk9qZ0QBJ7TUi9/Nha1uioc=; b=H5HLQwnJYlowV4BaCrk9lh4Rqv7LFNr1+ef9UuGrfs5uzMNGGH4S3gy1OrnNoSg1n4 qjp/UBXHnGGn1vs0uilbdhjR/qhdlhJpKTd9NxFS1BE5ZhEW2XuxKOspnRlJ+4skQPuH obC3duxwWHpG7NXn6/W1y7hs83JBQN9iCx+IVzi7b9VHiiqPZQpNL+zRrDOUuL88XfNn gIb9BTXH9zbiDnNL993P6oZIKIVEApD/z1PUM8nxlTqGIJSpp4aDemPjumqzx4KDDxOX oCkknATB88ysU2YL0ak/MykrNAe7SxDvIW8asaLYvRq6wxUgOscIZcZiesigfHfsq590 6UwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JYqsaLDo1+ctYQbIf4q0wk9qZ0QBJ7TUi9/Nha1uioc=; b=CfhAuDyRAme20SToNq5kDVoqTUpg3Lp618li3ggb91D3DNEcTugVZexLfc+Boi595z NZHeXvspkvOF1ZRoit+jcEGZSMMYCuhX8rQjnytiIL5S15LycaoyfUkIivtCRJqDWQ/u /VU83xj4wff8HL30MgYauv8KbZcpjOqfwGazH4QVMqfEvqW4/fxC+0ff50LqRz4oaUu5 IK2kTo5fw+t8KqRj/yNb3dPmUeisg9B0y38OUnbSPTpC1DTphQDsJPgCxsI82mhxTrhf Ohk8mcxqQeBp3RaAwRHqVFk07Cp7e+Ifm760ysrWYtYAjrAcCI4v6gJh8i435ZyBaP5K CFjw== X-Gm-Message-State: AOAM530Hp4ABf389ZWD0gL57vTAGUsTvatj8SrVojRiI5f22O/ahljt5 7jDv7amj5M3r/Loq5TscE4reEg== X-Google-Smtp-Source: ABdhPJzj1J9AKPe3dC+yW0U2xFyrVrE+rjSPK4kJgqTdJiq9AvDFHLk5Q3e/F/uvXBjPSr1yhPXXFg== X-Received: by 2002:ad4:54e9:: with SMTP id k9mr22510163qvx.18.1604328624605; Mon, 02 Nov 2020 06:50:24 -0800 (PST) Received: from localhost ([163.114.130.6]) by smtp.gmail.com with ESMTPSA id w5sm4316339qkj.102.2020.11.02.06.50.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:50:23 -0800 (PST) Date: Mon, 2 Nov 2020 09:48:39 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com Subject: Re: [PATCH v20 10/20] mm/swap.c: fold vm event PGROTATED into pagevec_move_tail_fn Message-ID: <20201102144839.GD724984@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-11-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-11-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 06:44:55PM +0800, Alex Shi wrote: > Fold the PGROTATED event collection into pagevec_move_tail_fn call back > func like other funcs does in pagevec_lru_move_fn. Thus we could save > func call pagevec_move_tail(). > Now all usage of pagevec_lru_move_fn are same and no needs of its 3rd > parameter. > > It's just simply the calling. No functional change. > > [lkp@intel.com: found a build issue in the original patch, thanks] > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Nice. Acked-by: Johannes Weiner