From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 146F6C388F2 for ; Mon, 2 Nov 2020 14:47:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9B5D62222B for ; Mon, 2 Nov 2020 14:47:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="XBPlkqmR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B5D62222B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 106786B0070; Mon, 2 Nov 2020 09:47:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B6916B0072; Mon, 2 Nov 2020 09:47:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0ECE6B0073; Mon, 2 Nov 2020 09:47:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id C32806B0070 for ; Mon, 2 Nov 2020 09:47:44 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5FEA71EE6 for ; Mon, 2 Nov 2020 14:47:44 +0000 (UTC) X-FDA: 77439757248.13.flag44_3808676272b0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 3AB2718140B67 for ; Mon, 2 Nov 2020 14:47:44 +0000 (UTC) X-HE-Tag: flag44_3808676272b0 X-Filterd-Recvd-Size: 4095 Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 14:47:43 +0000 (UTC) Received: by mail-qk1-f193.google.com with SMTP id o205so4840885qke.10 for ; Mon, 02 Nov 2020 06:47:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2EQEYsdl91ythedVS5CbIaac/O1VzM4oNTqK3zX2+mk=; b=XBPlkqmRr/I9IXZ93ewuFmXOVmiqScb7IKEEpyKP6hDEFveEL+2iyaWz2Rap78rQsv PhSuMRS+tMZrnEoCMtNlZCNPr/b8PcyBKL+rNSFR3VUw/vyM03pEOTBYs6io9c6W/+5V m+Yi9eLNS9TUDzPEVQhdtb5ey/6XoJUzJcdDErfRkkXJvIiSRGqsxEuJk9liWJNGQFDK X3/YKbeCkUS27pVkmCABhGYexhEMFN/wZAFRUhCRJjL4vH691liVm8mXQIKVywQUaney EkUScfWC0PqqjKvxYeTLKUz+ZuSOmqiwzWwymxMFkP+sz/oEs63OX32bcp6ytc90vdO2 gGuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2EQEYsdl91ythedVS5CbIaac/O1VzM4oNTqK3zX2+mk=; b=dUt5UWmiYoKfYUIvx0I2jS8LXEJ0EDMCylDVYalNZNi22H7lOQ6iexPvXkrLeSSVAm 2Bl8XXKZ1OSAYluy3jBL5OCj8pWEuRAxyaSlA9tRtegz3C3CpWtSGchmX3hZkM3/fEY5 dHK9vMGmARwOXjzMS8ao6Lxq8bz5zZ5Bk/1EnCJMLXn1Nh9teXXJnMTJWkqxTBxmImsU JfoDpBXyt42K57w0/YrCYdNfzzQsX5oChJw6is2EQupYhR5RU2oplo6O9hVbto+qMeNB IrANOZYZ0AavnoFW8BZ8Qgw5qsmFLD4RxIVTndbO0uGdaEAS4J8RYYDTVXxdpxBYNxXW a93g== X-Gm-Message-State: AOAM530DsXPbTCJPQd50AQV2RX02z1ooZZBF129LOHCipg1xOYLwPmZ/ B9VaT0OX0yaJSIg0CZb1u+d6Lg== X-Google-Smtp-Source: ABdhPJw5RAfqHvXVJPW3dOFsENGkqy36MuBPEwzggaN8V/NFBbnS3QZ12Rx3n9/XE58tqM2s26TmEw== X-Received: by 2002:a05:620a:21c4:: with SMTP id h4mr13587374qka.242.1604328462641; Mon, 02 Nov 2020 06:47:42 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:2f6e]) by smtp.gmail.com with ESMTPSA id 66sm5935254qkd.81.2020.11.02.06.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:47:41 -0800 (PST) Date: Mon, 2 Nov 2020 09:45:57 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Michal Hocko Subject: Re: [PATCH v20 09/20] mm/memcg: add debug checking in lock_page_memcg Message-ID: <20201102144557.GC724984@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-10-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-10-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 06:44:54PM +0800, Alex Shi wrote: > Add a debug checking in lock_page_memcg, then we could get alarm > if anything wrong here. > > Suggested-by: Johannes Weiner > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: Andrew Morton > Cc: cgroups@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Acked-by: Johannes Weiner