From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F287C00A89 for ; Mon, 2 Nov 2020 14:22:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC5E1206F8 for ; Mon, 2 Nov 2020 14:22:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="Bl4aWTuu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC5E1206F8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB7F96B0068; Mon, 2 Nov 2020 09:22:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3F9C6B006C; Mon, 2 Nov 2020 09:22:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D06756B006E; Mon, 2 Nov 2020 09:22:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 987236B0068 for ; Mon, 2 Nov 2020 09:22:17 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 222BD181AEF09 for ; Mon, 2 Nov 2020 14:22:17 +0000 (UTC) X-FDA: 77439693114.18.tail83_560178f272b0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id E137D100ED3B2 for ; Mon, 2 Nov 2020 14:22:16 +0000 (UTC) X-HE-Tag: tail83_560178f272b0 X-Filterd-Recvd-Size: 4494 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 14:22:15 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id r7so11585128qkf.3 for ; Mon, 02 Nov 2020 06:22:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RdeHhYw8BZ2CJOSRk/K/2wBpUG/X7Q+JV4i2mCHJHis=; b=Bl4aWTuuhh3ejAZOCKHG4CfQeBEfB/JUzCAQAwwU1q27w9LRBHw40b1lYkRV2Z8hA4 QCcwpiYoEuOFgqnb3iNq28m4KIyBBN5fOyI6VldOmXUxhedZDDNy42rJSFNdtD/CuZJX MV7RIrcafzrFPkz0mmz15xMivH5uzP8iAADoZEqaH7kPWlrxOMUuc8BeKWXpHibe0r3p fcaA3Qy5+TJ500b6ulilRT0xQoPC9fKNBdxAs1799SKZHJt3n+apv+8+3YA4xNakrj4u jL48OgCHNOr5IHRvjp5AZ5+wKcv4WXsDSKH3XjKhupMWKYXAbpQ7cCFP9/THuYXWkqCz l7pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RdeHhYw8BZ2CJOSRk/K/2wBpUG/X7Q+JV4i2mCHJHis=; b=XFGe1sqFTC9xVckxaoj87TncoZ9mUVhU+tyvt+E/Tjnzgwszm3oFKZ5f/7p3tFyaeO 7zFyYy0jHbzjX4AXlOCQ8kzQXUUr/DyvEiH8lEDUMLIFFM+MebB0ebJn2dk5QFOL8tZU 9VxYKPnaAg817G9CWUhm8eJIAKjnfudxgr/qDtTBsf/UscfyGnJ1zChEJiOgBFMUIPjh Q6zjAlvstzH9unifxBfWbMA7afDsoEJfAwIq5WZznegxDtlFMa28ENhsidO8KY966bk3 pwccLp44RFl+cnWrsTLcI46fKZGcXIdrniPdWTQxVEi3m+Vv1hErqwEDf4G61nreB3O5 AfQg== X-Gm-Message-State: AOAM530WWoBkTkOBt0ylRekjt/V4cpjYJLQLW3Hs2alL0YMgXvcICsO1 5Xu9IMBGMolLvjuFsjA2z7CnDg== X-Google-Smtp-Source: ABdhPJzZIStCA2Jj3cn0I/zoy13oct/CrY3KLukEVxstOKKufQU/+QSWdefmHTYBrA5eoxuzNcC7lg== X-Received: by 2002:a37:8d45:: with SMTP id p66mr14133765qkd.461.1604326935223; Mon, 02 Nov 2020 06:22:15 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:2f6e]) by smtp.gmail.com with ESMTPSA id 137sm6172331qkk.63.2020.11.02.06.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:22:14 -0800 (PST) Date: Mon, 2 Nov 2020 09:20:29 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com Subject: Re: [PATCH v20 07/20] mm/vmscan: remove unnecessary lruvec adding Message-ID: <20201102142029.GA724984@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-8-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-8-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 06:44:52PM +0800, Alex Shi wrote: > We don't have to add a freeable page into lru and then remove from it. > This change saves a couple of actions and makes the moving more clear. > > The SetPageLRU needs to be kept before put_page_testzero for list > integrity, otherwise: > > #0 move_pages_to_lru #1 release_pages > if !put_page_testzero > if (put_page_testzero()) > !PageLRU //skip lru_lock > SetPageLRU() > list_add(&page->lru,) > list_add(&page->lru,) > > [akpm@linux-foundation.org: coding style fixes] > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Tejun Heo > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Acked-by: Johannes Weiner