From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C9E5C388F2 for ; Mon, 2 Nov 2020 07:28:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D23FD221FF for ; Mon, 2 Nov 2020 07:28:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="t3kkl6+B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D23FD221FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E848A6B005C; Mon, 2 Nov 2020 02:28:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0EE66B005D; Mon, 2 Nov 2020 02:28:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C85936B0068; Mon, 2 Nov 2020 02:28:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 931146B005C for ; Mon, 2 Nov 2020 02:28:40 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2C2CA8249980 for ; Mon, 2 Nov 2020 07:28:40 +0000 (UTC) X-FDA: 77438650800.20.start17_5108454272ae Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 0E190180C07A3 for ; Mon, 2 Nov 2020 07:28:40 +0000 (UTC) X-HE-Tag: start17_5108454272ae X-Filterd-Recvd-Size: 3234 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf22.hostedemail.com (Postfix) with ESMTP for ; Mon, 2 Nov 2020 07:28:39 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1604302118; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vIeSJu/dxQMs46dPuG/9Z0PrnYcPG7vnkDWSjn2yCPc=; b=t3kkl6+BY+//ALDZFl4LH/zzn9lEK17PsBuQJOG4gFXTiEhMJtwEHDKk+6PBTvXUMY4qFF aOTAr32BOyEFFBx3huA3vrGlZfq49MNUifeOFqftPzL/YnudR8gNPUEuuEmMOXSTlQDfUd A2a6nupcbgZrgV91Fz//CP4kH6/8f/8= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 4EE79ACF6; Mon, 2 Nov 2020 07:28:38 +0000 (UTC) Date: Mon, 2 Nov 2020 08:28:36 +0100 From: Michal Hocko To: Hui Su Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] mm/oom_kill: change comment and rename is_dump_unreclaim_slabs() Message-ID: <20201102072836.GA22613@dhcp22.suse.cz> References: <20201027144529.GA3558@rlk> <20201027145814.GY20500@dhcp22.suse.cz> <20201027151156.GA4336@rlk> <20201027192322.GA20500@dhcp22.suse.cz> <20201028153141.GB77196@rlk> <20201030182704.GA53949@rlk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201030182704.GA53949@rlk> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat 31-10-20 02:27:04, Hui Su wrote: > Change the comment of is_dump_unreclaim_slabs(), it just check > whether nr_unreclaimable slabs amount is greater than user > memory, and explain why we dump unreclaim slabs. > > Rename it to should_dump_unreclaim_slab() maybe better. > > Signed-off-by: Hui Su Acked-by: Michal Hocko Thanks! > --- > mm/oom_kill.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 8b84661a6410..04b19b7b5435 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -170,11 +170,13 @@ static bool oom_unkillable_task(struct task_struct *p) > return false; > } > > -/* > - * Print out unreclaimble slabs info when unreclaimable slabs amount is greater > - * than all user memory (LRU pages) > - */ > -static bool is_dump_unreclaim_slabs(void) > +/** > + * Check whether unreclaimable slab amount is greater than > + * all user memory(LRU pages). > + * dump_unreclaimable_slab() could help in the case that > + * oom due to too much unreclaimable slab used by kernel. > +*/ > +static bool should_dump_unreclaim_slab(void) > { > unsigned long nr_lru; > > @@ -463,7 +465,7 @@ static void dump_header(struct oom_control *oc, struct task_struct *p) > mem_cgroup_print_oom_meminfo(oc->memcg); > else { > show_mem(SHOW_MEM_FILTER_NODES, oc->nodemask); > - if (is_dump_unreclaim_slabs()) > + if (should_dump_unreclaim_slab()) > dump_unreclaimable_slab(); > } > if (sysctl_oom_dump_tasks) > -- > 2.29.0 > > -- Michal Hocko SUSE Labs