From: Arvind Sankar <nivedita@alum.mit.edu>
To: Matthew Wilcox <willy@infradead.org>
Cc: Arvind Sankar <nivedita@alum.mit.edu>,
kernel test robot <lkp@intel.com>,
linux-next@vger.kernel.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
stable@vger.kernel.org, Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [PATCH] compiler.h: Move barrier() back into compiler-*.h
Date: Sun, 1 Nov 2020 14:51:10 -0500 [thread overview]
Message-ID: <20201101195110.GA1751707@rani.riverdale.lan> (raw)
In-Reply-To: <20201101173835.GC27442@casper.infradead.org>
On Sun, Nov 01, 2020 at 05:38:35PM +0000, Matthew Wilcox wrote:
> On Sun, Nov 01, 2020 at 12:31:05PM -0500, Arvind Sankar wrote:
> > Commit
> > b9de06783f01 ("compiler.h: fix barrier_data() on clang")
> > moved the definition of barrier() into compiler.h.
>
> That's not a real commit ID. It only exists in linux-next and
> will expire after a few weeks.
>
> The right way to fix a patch in Andrew's tree is to send an email
> asking him to apply it as a -fix patch. As part of Andrew's submission
> process, he folds all the -fix patches into the parent patch and it
> shows up pristine in Linus' tree.
Ok. So I still send it as a separate patch and he does the folding, or
should I send a revised patch that replaces the original one?
>
> > This causes build failures at least on alpha, because there are files
> > that rely on barrier() being defined via the implicit include of
> > compiler_types.h.
>
> That seems like a bug that should be fixed rather than reverting this
> part of the patch?
>
I thought about that, but barrier() is used in a large number of places,
so reverting seemed like the safer approach, in case more errors like
this cropped up. I don't know if it's a bug, as it was defined in
compiler_types.h before my original patch, I'm not sure if there's a
reason only compiler_types.h rather than compiler.h is implicitly
included via the Makefile.
Cc'ing Masahiro Yamada in case he has comments on that part.
Thanks.
next prev parent reply other threads:[~2020-11-01 19:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 13:07 [linux-next:master 2035/2472] include/asm-generic/barrier.h:78:18: error: implicit declaration of function 'barrier' kernel test robot
2020-11-01 17:31 ` [PATCH] compiler.h: Move barrier() back into compiler-*.h Arvind Sankar
2020-11-01 17:38 ` Matthew Wilcox
2020-11-01 17:48 ` Randy Dunlap
2020-11-01 17:53 ` Matthew Wilcox
2020-11-01 19:51 ` Arvind Sankar [this message]
2020-11-01 19:52 ` Matthew Wilcox
2020-11-01 19:59 ` Arvind Sankar
2020-11-01 20:40 ` Randy Dunlap
2020-11-01 21:59 ` Stephen Rothwell
2020-11-01 21:56 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201101195110.GA1751707@rani.riverdale.lan \
--to=nivedita@alum.mit.edu \
--cc=akpm@linux-foundation.org \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=lkp@intel.com \
--cc=masahiroy@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sfr@canb.auug.org.au \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox