From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 337CAC2D0A3 for ; Sun, 1 Nov 2020 10:50:25 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9A44D20756 for ; Sun, 1 Nov 2020 10:50:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ndxXGxT5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A44D20756 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DC5DD6B0070; Sun, 1 Nov 2020 05:50:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D76FD6B0072; Sun, 1 Nov 2020 05:50:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C67196B0073; Sun, 1 Nov 2020 05:50:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 9B1A56B0070 for ; Sun, 1 Nov 2020 05:50:23 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 2A3D8181AEF15 for ; Sun, 1 Nov 2020 10:50:23 +0000 (UTC) X-FDA: 77435530326.26.grape56_4f14bf1272a6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 041511804B660 for ; Sun, 1 Nov 2020 10:50:22 +0000 (UTC) X-HE-Tag: grape56_4f14bf1272a6 X-Filterd-Recvd-Size: 4188 Received: from smtprelay.test.hostedemail.com (mail.test.hostedemail.com [216.40.41.5]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Nov 2020 10:50:21 +0000 (UTC) Received: from forelay.test.hostedemail.com (10.5.29.251.rfc1918.com [10.5.29.251]) by smtprelay01.test.hostedemail.com (Postfix) with ESMTP id 257C411CEC for ; Sun, 1 Nov 2020 10:50:20 +0000 (UTC) Received: from forelay.prod.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by fograve01.test.hostedemail.com (Postfix) with ESMTP id DD3FE23810 for ; Sun, 1 Nov 2020 10:50:19 +0000 (UTC) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A24B6181AEF15 for ; Sun, 1 Nov 2020 10:50:09 +0000 (UTC) X-FDA: 77435529738.24.stick85_331074a272a6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 78B771A4A0 for ; Sun, 1 Nov 2020 10:50:09 +0000 (UTC) X-HE-Tag: stick85_331074a272a6 X-Filterd-Recvd-Size: 2130 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Sun, 1 Nov 2020 10:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BKLQptGlG/vyOKCfzKxQioEXXd2tw8LeC8qKoHogvio=; b=ndxXGxT53VbbnK0TWUGuF0eTNI bXEeJnNev4DagKgX2zHi1pHJXaN/0ZGn4bGnsSnuRoc+6HyKfq3HcOUexOsopvaWAmrBI2hA4Uvh1 8wPA7S7AufFO74z3Mg44iAAR2IsZ3guzp/TKXr6RjOSh5b4hXFnlyzKHgcnV9L5ZMo7A5TWhvoFqt AJLyhysk5gCB/hHyMRm4DNxLPhrOKuoayRqy/TdtcKWIYKXAdj1XE2kHI3a/lsy+eLuJhEzYZ+Acj FUAKTl99/mwoGScn4kS7zwqcPMWylbcyfaveeGQxJyiWp53eGRLspzN4g7hTqW7xtfdjMX6Hg6Rpk /WFvfZQg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZAvu-0002I6-Ts; Sun, 01 Nov 2020 10:49:59 +0000 Date: Sun, 1 Nov 2020 10:49:58 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Kent Overstreet , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 04/13] mm: handle readahead in generic_file_buffered_read_pagenotuptodate Message-ID: <20201101104958.GU27442@casper.infradead.org> References: <20201031090004.452516-1-hch@lst.de> <20201031090004.452516-5-hch@lst.de> <20201031170646.GT27442@casper.infradead.org> <20201101103144.GC26447@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201101103144.GC26447@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Nov 01, 2020 at 11:31:44AM +0100, Christoph Hellwig wrote: > This looks sensible, but goes beyond the simple refactoring I had > intended. Let me take a more detailed look at your series (I had just > updated my existing series to to the latest linux-next) and see how > it can nicely fit in. I'm also working on merging our two series. I'm just about there ...