From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BB90C388F7 for ; Sat, 31 Oct 2020 15:42:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B7DA722282 for ; Sat, 31 Oct 2020 15:42:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="HEB8Ig15" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7DA722282 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C48896B005C; Sat, 31 Oct 2020 11:42:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD2376B0062; Sat, 31 Oct 2020 11:42:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A99C86B006C; Sat, 31 Oct 2020 11:42:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 7A3146B005C for ; Sat, 31 Oct 2020 11:42:35 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 243B13626 for ; Sat, 31 Oct 2020 15:42:35 +0000 (UTC) X-FDA: 77432637870.15.star07_3d136da2729f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 0525C1814B0C1 for ; Sat, 31 Oct 2020 15:42:35 +0000 (UTC) X-HE-Tag: star07_3d136da2729f X-Filterd-Recvd-Size: 2262 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Sat, 31 Oct 2020 15:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sSLFkz3d1Cn8ttpMqHEgOVeNrly/EFMpMNdfgjMy8vs=; b=HEB8Ig15St5eZs4IfN6rX2YV6y aPWl4qfjNwnB78M1+o/sF49b42LwEZe/kgZo19mc+Z/4GUscOGT35XeN+W5eXYSh+VTcHlQQTG6Ny A+2UFf4o3+WoGvliczjezd/dcbGE6x0E+JSMPM2Z2Hnz1tEMvt8VHs2cHP9iJEYGWw2d0MA5wuQfT yfDNyedaGm2Ujwy0tWoNB0ZDHZPUvP6JS/mt5yFvZ4I+ND+Eyhklpvs0bO8r1wKLTMmnBYbia/uNG D9itnj6OxvGMxfqZ6Tb6hnlHhRbJdX2fnsRd/3XHIXCLauHez9n9leKSyx+3fY6rX7VqO0rs9YA+k GWhMYcQA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYt1P-0004Ik-Jl; Sat, 31 Oct 2020 15:42:27 +0000 Date: Sat, 31 Oct 2020 15:42:27 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Kent Overstreet , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: clean up the generic pagecache read helpers Message-ID: <20201031154227.GQ27442@casper.infradead.org> References: <20201031090004.452516-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201031090004.452516-1-hch@lst.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Oct 31, 2020 at 09:59:51AM +0100, Christoph Hellwig wrote: > Hi Andrew, > > this series cleans up refactors our generic read from page cache helpers. > The recent usage of the gang lookups helped a fair amount compared to > the previous state, but left some of the old mess and actually introduced > some new rather odd calling conventions as well. > > Matthew: I think this should actually help with your THP work even if it > means another rebase. I was a bit surprised how quickly the gang lookups > went in as well. I think this is 90% the same direction I'm heading in. I'll chime in with a few suggestions on the individual patches.