From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF78DC388F7 for ; Sat, 31 Oct 2020 09:02:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 179872067B for ; Sat, 31 Oct 2020 09:02:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="A4OWaP5f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 179872067B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3DD7E6B0036; Sat, 31 Oct 2020 05:02:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38FB26B005C; Sat, 31 Oct 2020 05:02:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 256526B005D; Sat, 31 Oct 2020 05:02:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id EECCA6B0036 for ; Sat, 31 Oct 2020 05:02:19 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 94C76180AD80F for ; Sat, 31 Oct 2020 09:02:19 +0000 (UTC) X-FDA: 77431629198.28.light13_150bc222729d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 74B9B6D74 for ; Sat, 31 Oct 2020 09:02:19 +0000 (UTC) X-HE-Tag: light13_150bc222729d X-Filterd-Recvd-Size: 2341 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Sat, 31 Oct 2020 09:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=PG0nI7edPosm36oEEbJMjxQzjtvR3xxB/F8bvCRxZaY=; b=A4OWaP5f0xdQ7mjBQmuYpNV/Bi WyLd8OXzXYao4XCbW86cV1UkceaMq6CZyb3tcXxHOFBH7dqypjuiaRhYuyzpyoJBRFq/hRFuAmQ6p p0w9DK0Jay3yaAVTd2wV4Txt3eIMG3NfmKu1MxDjpbFPFuDtGyor14d/JoMi7rUOBXzESTJ/9zu17 l+EfkjZOGkAul4VRdAar75tLcxxzR49UnnttmuSI8lN6Eem2WpVZjvLBKQNkCciZKnS3a7s4eteHH C7l1EYMj/pvMC16VZTsJAwiWmXQGMYo0MiRQUJuxtSI0APKm97evRCTeyTHMWTJQW4cc4XtJGN1BU Gj0hp6ZQ==; Received: from 089144193201.atnat0002.highway.a1.net ([89.144.193.201] helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYmm6-0006xP-I6; Sat, 31 Oct 2020 09:02:15 +0000 From: Christoph Hellwig To: Andrew Morton Cc: Kent Overstreet , Matthew Wilcox , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: clean up the generic pagecache read helpers Date: Sat, 31 Oct 2020 09:59:51 +0100 Message-Id: <20201031090004.452516-1-hch@lst.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, this series cleans up refactors our generic read from page cache helpers. The recent usage of the gang lookups helped a fair amount compared to the previous state, but left some of the old mess and actually introduced some new rather odd calling conventions as well. Matthew: I think this should actually help with your THP work even if it means another rebase. I was a bit surprised how quickly the gang lookups went in as well. Diffstat: fs/btrfs/file.c | 2=20 include/linux/fs.h | 4=20 mm/filemap.c | 337 ++++++++++++++++++++++------------------------= ------- 3 files changed, 149 insertions(+), 194 deletions(-)