From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09E37C00A89 for ; Fri, 30 Oct 2020 18:12:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4860E20729 for ; Fri, 30 Oct 2020 18:12:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="crzvGERl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4860E20729 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7F7FA6B0036; Fri, 30 Oct 2020 14:12:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CE4D6B005C; Fri, 30 Oct 2020 14:12:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E4736B005D; Fri, 30 Oct 2020 14:12:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id 422106B0036 for ; Fri, 30 Oct 2020 14:12:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DB77D33C4 for ; Fri, 30 Oct 2020 18:12:52 +0000 (UTC) X-FDA: 77429387784.30.swim52_4f04b6f27298 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id B2834180B3C8E for ; Fri, 30 Oct 2020 18:12:52 +0000 (UTC) X-HE-Tag: swim52_4f04b6f27298 X-Filterd-Recvd-Size: 2241 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Fri, 30 Oct 2020 18:12:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=m8D81kklIjOy7BvetEpdxNnGltgLU0sCcywzvVcT1hA=; b=crzvGERlf5EcYfWKpM3cyPxDmE SAozR2s9RBQuRy96mRAYuBOrsj+W1qYpMTYjkDYEmmT3L+oiS8Dho6f1kHFzddDA/snR2kjsDkzkA LxOUrdaCbBc5FECvupoxpdAZHL52BTQ437eQJWvAS57TItQZ5MMk4uPnFQs2aiisxoivVquL+LHZ8 LuDWiB87FO7PpT8NuLpB+9OO25vM6nQ9sD/onj3bx7BW0Ef2SOHqn1GH/BSW2mvdxc6nA7wxgGnIV lwyhBl+fyc1ar7gtz2m7dNd3VevGzDc57v+tSg4TQXm1XYk1vjx5mg1kHXs7LU6wLeKpMHsdfA/xh zKJzHS9g==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYYtK-00052F-5N; Fri, 30 Oct 2020 18:12:46 +0000 Date: Fri, 30 Oct 2020 18:12:46 +0000 From: Matthew Wilcox To: Zi Yan Cc: Andrew Morton , linux-mm@kvack.org, Yang Shi , Michal Hocko , Vlastimil Babka , Rik van Riel , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2 1/2] mm/compaction: count pages and stop correctly during page isolation. Message-ID: <20201030181246.GM27442@casper.infradead.org> References: <20201030155716.3614401-1-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201030155716.3614401-1-zi.yan@sent.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 30, 2020 at 11:57:15AM -0400, Zi Yan wrote: > In isolate_migratepages_block, when cc->alloc_contig is true, we are > able to isolate compound pages, nr_migratepages and nr_isolated did not > count compound pages correctly, causing us to isolate more pages than we > thought. Use thp_nr_pages to count pages. Otherwise, we might be trapped ^^^^^^^^^^^^ Maybe replace that sentence with "Count compound pages as the number of base pages they contain"?