From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45FE2C4363A for ; Fri, 30 Oct 2020 14:06:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5EE83221EB for ; Fri, 30 Oct 2020 14:06:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="YdSmPnE6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EE83221EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 43B0A6B0036; Fri, 30 Oct 2020 10:06:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ECF06B005D; Fri, 30 Oct 2020 10:06:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B52B6B0062; Fri, 30 Oct 2020 10:06:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0146.hostedemail.com [216.40.44.146]) by kanga.kvack.org (Postfix) with ESMTP id ED6E16B0036 for ; Fri, 30 Oct 2020 10:06:29 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 7502E3629 for ; Fri, 30 Oct 2020 14:06:29 +0000 (UTC) X-FDA: 77428766898.29.son95_210471f27296 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 581011802C531 for ; Fri, 30 Oct 2020 14:06:06 +0000 (UTC) X-HE-Tag: son95_210471f27296 X-Filterd-Recvd-Size: 5405 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Fri, 30 Oct 2020 14:06:05 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id a64so1507157qkc.5 for ; Fri, 30 Oct 2020 07:06:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=XFvLixYNsnzdj4toTcnFoItKGAiR6MimcB7uXhxEsAY=; b=YdSmPnE65j6ZxU34kUIayYUWOJdr/r9gmpdMjuHb3lqo4k7Ldna9+SpQYp+Q/O0rpo WDajdXIoc3E12pCo7NqjkA5VdTd3GcxyIs6fRkV9TDwZFbcvFqV+vpX1kEwgkglssWVp hrXznUwOVgnLP4ssAB6TzjQZYCZCsYzKg3NFhoUAkFoL5+R2IA2zHpXGCyjZ/IF6/MMx gqFNMF1zPrQ27+qJm3plMXyMAHfqxPv8dn/ClpIMvSHlmfhmD44gWnz56F6/+2+9h2y+ kYQTmd6XxzlYFlW17S94k8DW9B2C0Zx8DoGp66gvVqRDJ3ZbNZTsrXicfYnke5xW9AFr 1v2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=XFvLixYNsnzdj4toTcnFoItKGAiR6MimcB7uXhxEsAY=; b=bqSukrKpGF8XZ1xUS88X78nw4SK2ei+OnNOln924uX5Ru+bY4hLNa7Q4hri0dk6MGy gKkbB2c+wtdfLk/U157H4qVHPV6WU/ff/T5ol6C/zDEN3Am5OHRKI3XQbOBY9g/VgiZR wI7cN59RWt/WgqMz5Jr2lAV1f2g4UBbSb6Nq7NHFew0RWSIIyOMjM8AdJm3/lqu85Wdn ZAPgBbjfB8+iEhWsBdph3xKVR8bcg9V4lt/doX+8cwk2pWg2d/uCA25KAX5ol4AwQb+v t5YQGNfwWvODVGz/JmbtmI1R98LQKwUCoc4Dxipg6HnzMq/GaCgR6Z+eLnQFIKtLYs5P ULhQ== X-Gm-Message-State: AOAM533CvCKYMqCtgedVNEoHbSvsAX7yd6by9afeIC8vLIfmWycqEGm4 QWuPVg/WdQTlepYiL4aMsd3n+w== X-Google-Smtp-Source: ABdhPJy6GSdDtgopMaSrcuhTI50F6OgXI/etTV6OK///4TfnmY4zL1gXH/AwTDzNi59Yk5VOzZtUbA== X-Received: by 2002:ae9:e802:: with SMTP id a2mr2343108qkg.227.1604066764803; Fri, 30 Oct 2020 07:06:04 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:fb53]) by smtp.gmail.com with ESMTPSA id 19sm2609429qki.33.2020.10.30.07.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 07:06:03 -0700 (PDT) Date: Fri, 30 Oct 2020 10:04:20 -0400 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Michal Hocko Subject: Re: [PATCH v20 02/20] mm/memcg: bail early from swap accounting if memcg disabled Message-ID: <20201030140420.GB666074@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-3-git-send-email-alex.shi@linux.alibaba.com> <20201029134648.GC599825@cmpxchg.org> <96b6d122-df0e-dfb0-368c-6bd714fab116@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <96b6d122-df0e-dfb0-368c-6bd714fab116@linux.alibaba.com> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 30, 2020 at 10:27:51AM +0800, Alex Shi wrote: >=20 >=20 > =E5=9C=A8 2020/10/29 =E4=B8=8B=E5=8D=889:46, Johannes Weiner =E5=86=99=E9= =81=93: > >> ? release_pages+0x1ae/0x410 > >> shmem_alloc_and_acct_page+0x77/0x1c0 > >> shmem_getpage_gfp+0x162/0x910 > >> shmem_fault+0x74/0x210 > >> ? filemap_map_pages+0x29c/0x410 > >> __do_fault+0x37/0x190 > >> handle_mm_fault+0x120a/0x1770 > >> exc_page_fault+0x251/0x450 > >> ? asm_exc_page_fault+0x8/0x30 > >> asm_exc_page_fault+0x1e/0x30 > >> > >> Signed-off-by: Alex Shi > >> Reviewed-by: Roman Gushchin > >> Acked-by: Michal Hocko > >> Acked-by: Hugh Dickins > >> Cc: Johannes Weiner > >> Cc: Michal Hocko > >> Cc: Vladimir Davydov > >> Cc: Andrew Morton > >> Cc: cgroups@vger.kernel.org > >> Cc: linux-mm@kvack.org > >> Cc: linux-kernel@vger.kernel.org > > Acked-by: Johannes Weiner > >=20 > > This should go in before the previous patch that adds the WARN for it= . >=20 > Right, but than the long ops may not weird. Should I remove the ops and= resend the whole patchset? You mean the warning in the changelog? I think that's alright. You can just say that you're about to remove the !page->memcg check in the next patch because the original reasons for having it are gone, and memcg being disabled is the only remaining exception, so this patch makes that check explicit in preparation for the next. Sorry, it's all a bit of a hassle, I just wouldn't want to introduce a known warning into the kernel between those two patches (could confuse bisection runs, complicates partial reverts etc.)