From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3178C4742C for ; Fri, 30 Oct 2020 00:05:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5018020724 for ; Fri, 30 Oct 2020 00:05:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DuLV5SSd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5018020724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B06806B0062; Thu, 29 Oct 2020 20:05:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB8A26B006C; Thu, 29 Oct 2020 20:05:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CE636B006E; Thu, 29 Oct 2020 20:05:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 717806B0062 for ; Thu, 29 Oct 2020 20:05:40 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1762A8249980 for ; Fri, 30 Oct 2020 00:05:40 +0000 (UTC) X-FDA: 77426648040.18.sound57_240855827291 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id E65F4100ED3AB for ; Fri, 30 Oct 2020 00:05:39 +0000 (UTC) X-HE-Tag: sound57_240855827291 X-Filterd-Recvd-Size: 3357 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Fri, 30 Oct 2020 00:05:37 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id k6so4973944ilq.2 for ; Thu, 29 Oct 2020 17:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6NWXJurSDAUdvVulUBS08ycCbDD8zDtUY/wRER/Pl6w=; b=DuLV5SSd8IBfdgg0JIjsJeXUQtNhy2jTDNdmjG4MhkPpGlibrast3VKlviEg3Its/o bYUj5gmPFXkvDw6oGJPr8PG0BvCsf4oSaqIe65I30Yo5pVvHSijzGEWaKjL+MpmVsgs6 va6QV1rsD+q6Rx3vFFQquOVAFG9wYAl2pjgU3K+RaHOlow4qUIqNrpgMjO1rgIfvX/rw bGcJvf/9edofTvPa5aWYMOIdVK1nZkYGZas/Z/66NFmR8Xl8Pw+99QtrHIlUP8eTLZOq 9YzwnBN+nO+N2v/nq5ByuaWP6oxwFA4z3E6C9aYTYPrByxEIMzk144hD6a445WnlYYy8 p16g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6NWXJurSDAUdvVulUBS08ycCbDD8zDtUY/wRER/Pl6w=; b=ZRclO59svJ4jr63CTTp3EutYmFmlUhqg+5aRDY0WSwo4Mdxl0BlSw6SgJjRkckDQjX vx7D0ZEzytlEVlzE9DyGxnpCN7kymdc5wJnFr5n79EU2v4QqAnnRYvLE6+nreZAYWHPo j4Sjd69SRI8s4NtBOD3D8U9z2kGJJYu6fxKuixebVHJS0MSUy1+JubPRtRctLi2EGENr 7639BNIYdQ039LP/DeYjb9SFd5QWvA54qFp2xFFZwicE+Bi0/notxgZgMcE0ABB2C98z teRgvGFZTS4KrvVa7X9Ci/C5W7PK7oK0NVyiaOwAcC7OZKMmRsvunbI6ZsjTURMGPhNM TEWA== X-Gm-Message-State: AOAM533LcsB5ueTL1Zz670GRAMbxpd/oNk491gXrYnYHmlLKiCMj1NtT oALt71fYKuL2psX886WnCQ== X-Google-Smtp-Source: ABdhPJzUxcYp+6xyOi2e7drSpHb7Nwl1WMo0auV/RLkHOg8N6uSfnnb/EZIhx25RGvjSmNB5t4L01A== X-Received: by 2002:a92:ddd1:: with SMTP id d17mr5271897ilr.275.1604016337618; Thu, 29 Oct 2020 17:05:37 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id p18sm3457596ile.72.2020.10.29.17.05.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 17:05:37 -0700 (PDT) Date: Thu, 29 Oct 2020 20:05:35 -0400 From: Kent Overstreet To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 06/19] mm/filemap: Change calling convention for gfbr_ functions Message-ID: <20201030000535.GB2123636@moria.home.lan> References: <20201029193405.29125-1-willy@infradead.org> <20201029193405.29125-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029193405.29125-7-willy@infradead.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.001458, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 07:33:52PM +0000, Matthew Wilcox (Oracle) wrote: > gfbr_update_page() would prefer to have mapping passed to it than filp, > as would gfbr_create_page(). That makes gfbr_read_page() retrieve > the file pointer from the iocb. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Kent Overstreet