From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23840C55179 for ; Thu, 29 Oct 2020 13:52:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 644DB206DD for ; Thu, 29 Oct 2020 13:52:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="gcRq1IeI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 644DB206DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 983D46B0078; Thu, 29 Oct 2020 09:52:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 934416B007D; Thu, 29 Oct 2020 09:52:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FB526B007E; Thu, 29 Oct 2020 09:52:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0179.hostedemail.com [216.40.44.179]) by kanga.kvack.org (Postfix) with ESMTP id 516226B0078 for ; Thu, 29 Oct 2020 09:52:38 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E2B7E8249980 for ; Thu, 29 Oct 2020 13:52:37 +0000 (UTC) X-FDA: 77425103154.10.suit36_2d1835a2728d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id C27E116A044 for ; Thu, 29 Oct 2020 13:52:37 +0000 (UTC) X-HE-Tag: suit36_2d1835a2728d X-Filterd-Recvd-Size: 4577 Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 13:52:37 +0000 (UTC) Received: by mail-il1-f194.google.com with SMTP id z2so3028305ilh.11 for ; Thu, 29 Oct 2020 06:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5MfKe3DP7slEVa5weBChPOdwKwukAel2TnvkgswMss4=; b=gcRq1IeIkaEAkPFS5WKi2EPbUk5OEhwyFRIn/uaI+vOq8JeipGnDYtfvu5hPSgvNMA +bd5ninFYWFlPInI6dcTy24RZXWatQtR7EajDSee3Gw76Ru+sshSeR7uDtaaOpAnzqht M+HgpBZJiUIUGmXcDxHju67QR5p3CRkGlQMQdbKGZLG0TkOfScdJMYnEufC4/tEPY/4K 36jdPDiqUEOkLh48UffqE2EAsI0wugobZ32NeGkq7pT7eOzUNkCemRWkTzOHU0CRlptw IR7EEi5NU9fJ3XOP0eUD7clmNTAYd5R+/cBVDyhT6Xw0+1wkeWcHtkoC1f8c7KJBf+0e Kc1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5MfKe3DP7slEVa5weBChPOdwKwukAel2TnvkgswMss4=; b=Naqt9jxrWjRSV1leLVcf4VRfPkhLtnYoTph7wjG9CoWXDshCAC8cGrt/rrPKlcyaRO iuun2uuyniMjzmHWjW3MlDuJrirV6fWpqX4pPdYfSfnjMdeZbw/scaOTJojrzVIQJStG x4XkkAQOf0Zz6cXnnmaG9dBqPCunc14nz84W5AliObRMtKh0kKEeEAuTrX0czNdnDN0S +z/ky/usZlrNO5ZD9t8DL2BXgnRCWRwbQewV+1aoOUI7NGyBH/lAui+DpgxvGZQV40dd +c0TFki3F9Um4qMef41tM1G4IAcqeEZnSo5lHpCEkGlmKVOFqFTbG4xH6D3uyvrcbjWG bkVg== X-Gm-Message-State: AOAM53099UyeM64rY7P6kMSbJYMs3OwXaHEi5LgJGnKGctCjBVyfX/WE mfYet42qf6gUoLX5+FLIv2du5Q== X-Google-Smtp-Source: ABdhPJz0XWo8QheEqFIqLHIMdoioU+V5spY7FVVmUawog+0XCjCMYK7pBDQO+KfqQnhZ0KUnFK0SYg== X-Received: by 2002:a92:aa01:: with SMTP id j1mr3469159ili.301.1603979556570; Thu, 29 Oct 2020 06:52:36 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:536c]) by smtp.gmail.com with ESMTPSA id m66sm3217846ill.69.2020.10.29.06.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 06:52:35 -0700 (PDT) Date: Thu, 29 Oct 2020 09:50:47 -0400 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com Subject: Re: [PATCH v20 04/20] mm/thp: use head for head page in lru_add_page_tail Message-ID: <20201029135047.GE599825@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-5-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-5-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 06:44:49PM +0800, Alex Shi wrote: > Since the first parameter is only used by head page, it's better to make > it explicit. > > Signed-off-by: Alex Shi > Reviewed-by: Kirill A. Shutemov > Acked-by: Hugh Dickins > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > --- > mm/huge_memory.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 038db815ebba..93c0b73eb8c6 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2346,19 +2346,19 @@ static void remap_page(struct page *page, unsigned int nr) > } > } > > -static void lru_add_page_tail(struct page *page, struct page *page_tail, > +static void lru_add_page_tail(struct page *head, struct page *page_tail, It may be better to pick either head and tail or page_head and page_tail ?