From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49810C4363A for ; Thu, 29 Oct 2020 13:49:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BAE9520825 for ; Thu, 29 Oct 2020 13:49:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="Rkh4mNNW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAE9520825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD32D6B0078; Thu, 29 Oct 2020 09:49:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D82446B007B; Thu, 29 Oct 2020 09:49:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4B266B007D; Thu, 29 Oct 2020 09:49:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id 953C76B0078 for ; Thu, 29 Oct 2020 09:49:21 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 43029180AD815 for ; Thu, 29 Oct 2020 13:49:21 +0000 (UTC) X-FDA: 77425094922.09.work29_55158ed2728d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 2483F180AD80F for ; Thu, 29 Oct 2020 13:49:21 +0000 (UTC) X-HE-Tag: work29_55158ed2728d X-Filterd-Recvd-Size: 4155 Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 13:49:20 +0000 (UTC) Received: by mail-il1-f196.google.com with SMTP id x7so3059432ili.5 for ; Thu, 29 Oct 2020 06:49:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aaIMvQUgy5GfKnfOz1OmQc/tQFUJWmKT+5EU7lJnpIg=; b=Rkh4mNNWCGTBaZ0kV3h45r9aCfQYTEYCWwhRTXhZukO72CfLpaYAPvSKsRefVLAzBS XY2eapgWAFWjyUUoH7y9nXTAJxwWC0HpyKLRREWAnnPufo2nFhCVDJwAxmSRiG1SmYRt 6de9omlzVlZi/CoRpBC8oLf0Zij5KZIx0kMdZbchDA9917NbYrk8f8zEeYVWy2US9YjA rcbo+L01DJPTZi0FIodyReVMGdqEpBmGzPA6I4C628VHdPh3HjvJyu+YvqWL6rvh+ovW n34QeAf/1/kiOVFLMOiZqY0/zzh8MIaom8wOQ4Bn/zCvhHIA8fL2jeT3TJy7SmFibzxX yETg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aaIMvQUgy5GfKnfOz1OmQc/tQFUJWmKT+5EU7lJnpIg=; b=oyOi0kmmD9Cw2sU+zrJs4SRD3D6Az13RMlBX+wxyH3se08+t/1Tgq7sOfp8UCIACR8 +MJ0LiZ4LrLXJ68p8ClTJ5q2HlH6Pk402ZB7O2DFjn320OMiH8Lt1Nj6TCLHvehTjlp6 jYkq9OKakjhldlz725YYofTM7SDPyqPy6RM//q8HtVUVbRqdN1BrfL80b+G+CTLknNy2 sxAbDZQwl1UBg8hL02mIeQF3cLTeW4VclBZF7O68uIZY5B5wLTfJLwBSMkvRtYoqxEkG ap84TnOpq0LgDXh2j7KHR8PR7dquEcHp+b4h4BsrP7FO/gO4qY0xIjUYXs/DvqwA/Du5 i2Og== X-Gm-Message-State: AOAM530zw6N/LXxXKvd5WyZ4qy9pTiZupkvFSvfytGNP/1Fc/ieK8TyZ pctlQe4QAVNtq6+FcFB+8cVLHw== X-Google-Smtp-Source: ABdhPJx6akD2dWp5vXCJd42qFVzh3uxf4Fx0OHthh0wIVykcUn348X8rO6ye2ci3U/17ms/WaumXwg== X-Received: by 2002:a05:6e02:ca9:: with SMTP id 9mr2947150ilg.96.1603979360131; Thu, 29 Oct 2020 06:49:20 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:536c]) by smtp.gmail.com with ESMTPSA id n84sm2881225ild.16.2020.10.29.06.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 06:49:19 -0700 (PDT) Date: Thu, 29 Oct 2020 09:47:36 -0400 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com Subject: Re: [PATCH v20 03/20] mm/thp: move lru_add_page_tail func to huge_memory.c Message-ID: <20201029134736.GD599825@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-4-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-4-git-send-email-alex.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 29, 2020 at 06:44:48PM +0800, Alex Shi wrote: > The func is only used in huge_memory.c, defining it in other file with a > CONFIG_TRANSPARENT_HUGEPAGE macro restrict just looks weird. > > Let's move it THP. And make it static as Hugh Dickin suggested. > > Signed-off-by: Alex Shi > Reviewed-by: Kirill A. Shutemov > Acked-by: Hugh Dickins > Cc: Andrew Morton > Cc: Johannes Weiner > Cc: Matthew Wilcox > Cc: Hugh Dickins > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org Acked-by: Johannes Weiner