From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71226C55178 for ; Thu, 29 Oct 2020 09:04:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B92832075E for ; Thu, 29 Oct 2020 09:04:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="dhcd+7qq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B92832075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC0296B005C; Thu, 29 Oct 2020 05:04:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E4A5E6B0062; Thu, 29 Oct 2020 05:04:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE9796B0068; Thu, 29 Oct 2020 05:04:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id 9893D6B005C for ; Thu, 29 Oct 2020 05:04:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3AD18180AD81A for ; Thu, 29 Oct 2020 09:04:24 +0000 (UTC) X-FDA: 77424376848.30.juice59_59049332728c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 193B7180B3C85 for ; Thu, 29 Oct 2020 09:04:24 +0000 (UTC) X-HE-Tag: juice59_59049332728c X-Filterd-Recvd-Size: 5394 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Thu, 29 Oct 2020 09:04:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603962262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oOcANBdMPXC7B2WLthX/pictznBjPuN497vi+SoY2Xs=; b=dhcd+7qqKCXHjOBxV2Cg7MiZML1GKPSWVlBB9FvKKYdgskekurmRpBQNM+RI6MvGVqp+Jy rHDoUBCvqVGqB6VmHZ4YrMOJHX2JPN5EgX4efyqaLFx9qsziq9sLEQ92ttTPgewslMFBPo vtnWnT1j6OGk084gTe9UcCdgAqlEQRc= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 16A7EAC65; Thu, 29 Oct 2020 09:04:22 +0000 (UTC) Date: Thu, 29 Oct 2020 10:04:21 +0100 From: Michal Hocko To: Huang Ying Cc: Peter Zijlstra , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Matthew Wilcox (Oracle)" , Rafael Aquini , Andrew Morton , Ingo Molnar , Mel Gorman , Rik van Riel , Johannes Weiner , Dave Hansen , Andi Kleen , David Rientjes Subject: Re: [PATCH -V2 1/2] mempolicy: Rename MPOL_F_MORON to MPOL_F_MOPRON Message-ID: <20201029090421.GC17500@dhcp22.suse.cz> References: <20201028023411.15045-1-ying.huang@intel.com> <20201028023411.15045-2-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201028023411.15045-2-ying.huang@intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 28-10-20 10:34:10, Huang Ying wrote: > To follow code-of-conduct better. This is changing a user visible interface and any userspace which refers to the existing name will fail to compile unless I am missing something. Have you checked how many applications would be affected? Btw I find "follow CoC better" a very weak argument without further explanation. > Signed-off-by: "Huang, Ying" > Suggested-by: "Matthew Wilcox (Oracle)" > Acked-by: Rafael Aquini > Cc: Andrew Morton > Cc: Ingo Molnar > Cc: Mel Gorman > Cc: Rik van Riel > Cc: Johannes Weiner > Cc: Dave Hansen > Cc: Andi Kleen > Cc: Michal Hocko > Cc: David Rientjes > Cc: Rafael Aquini > --- > include/uapi/linux/mempolicy.h | 2 +- > kernel/sched/debug.c | 2 +- > mm/mempolicy.c | 6 +++--- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/uapi/linux/mempolicy.h b/include/uapi/linux/mempolicy.h > index 3354774af61e..3c3666d017e6 100644 > --- a/include/uapi/linux/mempolicy.h > +++ b/include/uapi/linux/mempolicy.h > @@ -60,7 +60,7 @@ enum { > #define MPOL_F_SHARED (1 << 0) /* identify shared policies */ > #define MPOL_F_LOCAL (1 << 1) /* preferred local allocation */ > #define MPOL_F_MOF (1 << 3) /* this policy wants migrate on fault */ > -#define MPOL_F_MORON (1 << 4) /* Migrate On protnone Reference On Node */ > +#define MPOL_F_MOPRON (1 << 4) /* Migrate On Protnone Reference On Node */ > > > #endif /* _UAPI_LINUX_MEMPOLICY_H */ > diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c > index 0655524700d2..8bfb6adb3f31 100644 > --- a/kernel/sched/debug.c > +++ b/kernel/sched/debug.c > @@ -898,7 +898,7 @@ static void sched_show_numa(struct task_struct *p, struct seq_file *m) > > task_lock(p); > pol = p->mempolicy; > - if (pol && !(pol->flags & MPOL_F_MORON)) > + if (pol && !(pol->flags & MPOL_F_MOPRON)) > pol = NULL; > mpol_get(pol); > task_unlock(p); > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 3fde772ef5ef..f6948b659643 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -2511,7 +2511,7 @@ int mpol_misplaced(struct page *page, struct vm_area_struct *vma, unsigned long > } > > /* Migrate the page towards the node whose CPU is referencing it */ > - if (pol->flags & MPOL_F_MORON) { > + if (pol->flags & MPOL_F_MOPRON) { > polnid = thisnid; > > if (!should_numa_migrate_memory(current, page, curnid, thiscpu)) > @@ -2802,7 +2802,7 @@ void __init numa_policy_init(void) > preferred_node_policy[nid] = (struct mempolicy) { > .refcnt = ATOMIC_INIT(1), > .mode = MPOL_PREFERRED, > - .flags = MPOL_F_MOF | MPOL_F_MORON, > + .flags = MPOL_F_MOF | MPOL_F_MOPRON, > .v = { .preferred_node = nid, }, > }; > } > @@ -3010,7 +3010,7 @@ void mpol_to_str(char *buffer, int maxlen, struct mempolicy *pol) > unsigned short mode = MPOL_DEFAULT; > unsigned short flags = 0; > > - if (pol && pol != &default_policy && !(pol->flags & MPOL_F_MORON)) { > + if (pol && pol != &default_policy && !(pol->flags & MPOL_F_MOPRON)) { > mode = pol->mode; > flags = pol->flags; > } > -- > 2.28.0 > -- Michal Hocko SUSE Labs