From: Roman Gushchin <guro@fb.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: <hannes@cmpxchg.org>, <mhocko@kernel.org>,
<vdavydov.dev@gmail.com>, <akpm@linux-foundation.org>,
<shakeelb@google.com>, <iamjoonsoo.kim@lge.com>,
<laoar.shao@gmail.com>, <chris@chrisdown.name>,
<christian.brauner@ubuntu.com>, <peterz@infradead.org>,
<mingo@kernel.org>, <keescook@chromium.org>, <tglx@linutronix.de>,
<esyr@redhat.com>, <surenb@google.com>, <areber@redhat.com>,
<elver@google.com>, <linux-kernel@vger.kernel.org>,
<cgroups@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg
Date: Wed, 28 Oct 2020 17:16:35 -0700 [thread overview]
Message-ID: <20201029001635.GG827280@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201028035013.99711-1-songmuchun@bytedance.com>
On Wed, Oct 28, 2020 at 11:50:10AM +0800, Muchun Song wrote:
> Consider the following memcg hierarchy.
>
> root
> / \
> A B
>
> If we get the objcg of memcg A failed, the get_obj_cgroup_from_current
> can return the wrong objcg for the root memcg.
>
> Fixes: bf4f059954dc ("mm: memcg/slab: obj_cgroup API")
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
next prev parent reply other threads:[~2020-10-29 0:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 3:50 Muchun Song
2020-10-28 3:50 ` [PATCH v2] mm: memcg/slab: Fix use after free in obj_cgroup_charge Muchun Song
2020-10-29 15:52 ` Shakeel Butt
2020-11-10 3:19 ` Muchun Song
2020-10-28 3:50 ` [PATCH v2] mm: memcg/slab: Rename *_lruvec_slab_state to *_lruvec_kmem_state Muchun Song
2020-10-29 15:52 ` Shakeel Butt
2020-10-28 3:50 ` [PATCH v2] mm: memcontrol: Simplify the mem_cgroup_page_lruvec Muchun Song
2020-10-29 9:08 ` Michal Hocko
2020-10-29 16:01 ` Shakeel Butt
2020-10-29 16:13 ` Michal Hocko
2020-10-29 0:16 ` Roman Gushchin [this message]
2020-10-29 15:48 ` [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg Shakeel Butt
2020-10-29 16:08 ` [External] " Muchun Song
2020-10-29 16:18 ` Shakeel Butt
2020-10-29 16:32 ` Muchun Song
2020-10-29 17:09 ` Roman Gushchin
2020-10-29 20:34 ` Shakeel Butt
2020-10-29 21:25 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029001635.GG827280@carbon.dhcp.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=areber@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=christian.brauner@ubuntu.com \
--cc=elver@google.com \
--cc=esyr@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox