From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A76AC388F7 for ; Wed, 28 Oct 2020 15:46:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6DA9D247D2 for ; Wed, 28 Oct 2020 15:46:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bVgcOJND" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DA9D247D2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A75AC6B0062; Wed, 28 Oct 2020 11:46:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A019B6B0068; Wed, 28 Oct 2020 11:46:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C7606B0071; Wed, 28 Oct 2020 11:46:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id 5BE776B0062 for ; Wed, 28 Oct 2020 11:46:18 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EA80D180AD806 for ; Wed, 28 Oct 2020 15:46:17 +0000 (UTC) X-FDA: 77421760794.25.fly02_2e1614227285 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id BB2881804E3A8 for ; Wed, 28 Oct 2020 15:46:17 +0000 (UTC) X-HE-Tag: fly02_2e1614227285 X-Filterd-Recvd-Size: 5664 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Oct 2020 15:46:17 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id w23so10035wmi.4 for ; Wed, 28 Oct 2020 08:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jxN7dwqApdR1ej5dh2h2T4IB4++cE/G2cOg1rxvC1QU=; b=bVgcOJNDYGFVmRhLRE5zDu1fTUWAdDMpxxBtb+q8OcZmy5i6QdU4+VmbQQKjjt02SU uf+n3paPdIQPEufyNwNrkkSC8uRV5UHdGk5fL6iKJwhxXsfK007LvehHdsIdkYD/vkwl MF3RqolRLeULiKOhMAJ+KtH4XAyC9l0aOO7dY+oMvzchh72LIch6SRcr3Vxxsiv3d969 uDyHgZZ+lku4criVmIJ6F7ax7e0vb4zW8oy/yvd9pKD0qr2YNoiStv1aeVEOFH2HYLQn wVKirUiTe5QH1258QCNhLvWqHrZcdPSYKgZ4+nJ/3pDnQkxtFLkkLZRNBYOwTuiN6lMe tHCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jxN7dwqApdR1ej5dh2h2T4IB4++cE/G2cOg1rxvC1QU=; b=qMgFeb51Cf89OLcMhcNEb6oxlL8Q6te07+IFTE4aZxfAL1+XVYgsfrJhjefyix+fHz RUVmtWqOr8+iXbjOcrKk0/vz8QPD4iL8KqWBqddyxHVGscOJlAioTKRb1tDoO5TVGCSQ cDAEuMqjxO9jI09hPNqrXciB5O6qQci4hheC6DhdIdMZ2MF5BqGDlDQzWGJzI5ZRIF42 CGUZZ7a7PZGi8H56OG6ry+j2MWgzfn14gOpbwW6VO/mTGCn4Xu3ZIP5SydSX7xVXWqNn YCCFgue5DQaH3guL6YsaTcIJaQctVdaZY2FxfUptkMxojNJiil3pYhfn+1y3tcWPbCAP n8RA== X-Gm-Message-State: AOAM531DIjWPfb8+Jfp6Bp66X6rv4ZSoz24Pg1I/E5ST3UlVOvPlc7hK imxKtP5UJ/9HtKTeb+F4KOHxSQ== X-Google-Smtp-Source: ABdhPJxugL/06UijjpouyBtDh42aboeAqgIFcJ7a1QLSdDZlftvXVGOyggzHDRsaGqPXkkSDAVWXnQ== X-Received: by 2002:a05:600c:2049:: with SMTP id p9mr6483756wmg.147.1603899975882; Wed, 28 Oct 2020 08:46:15 -0700 (PDT) Received: from holly.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id p4sm7367869wrf.67.2020.10.28.08.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 08:46:15 -0700 (PDT) Date: Wed, 28 Oct 2020 15:46:13 +0000 From: Daniel Thompson To: Andrew Morton Cc: kernel test robot , Andrey Konovalov , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, Linux Memory Management List Subject: Re: drivers/video/backlight/ltv350qv.c:192:12: warning: stack frame size of 13472 bytes in function 'ltv350qv_power' Message-ID: <20201028154613.fue7ilxdihj2cado@holly.lan> References: <202010260230.VivTG0Gb-lkp@intel.com> <20201025121708.04d4070a44e28146baf9a6a7@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201025121708.04d4070a44e28146baf9a6a7@linux-foundation.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Oct 25, 2020 at 12:17:08PM -0700, Andrew Morton wrote: > On Mon, 26 Oct 2020 02:15:37 +0800 kernel test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > head: d76913908102044f14381df865bb74df17a538cb > > commit: cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4 kasan: allow enabling stack tagging for tag-based mode > > date: 3 months ago > > config: arm64-randconfig-r005-20201026 (attached as .config) > > compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1c8371692dfe8245bc6690ff1262dcced4649d21) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # install arm64 cross compiling tool for clang build > > # apt-get install binutils-aarch64-linux-gnu > > # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4 > > git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > git fetch --no-tags linus master > > git checkout cae9dc35ed9ff82a99754e51d57ff6c332e1f7e4 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All warnings (new ones prefixed by >>): > > > > >> drivers/video/backlight/ltv350qv.c:192:12: warning: stack frame size of 13472 bytes in function 'ltv350qv_power' [-Wframe-larger-than=] > > That's a lot of stack. > > > static int ltv350qv_power(struct ltv350qv *lcd, int power) > > ^ > > 1 warning generated. > > > > vim +/ltv350qv_power +192 drivers/video/backlight/ltv350qv.c > > Odd - the code looks pretty normal. It is possible that your compiler > is (crazily) inlining ltv350qv_write_reg()? Certainly could be. Same config compiled with gcc-9 gives ltv350qv_write_reg() a stack usage that is large but not crazy: 768 bytes and dropping to 480 bytes with the sanitizers disabled. With the sanitizers enabled then even the cumulative stack usage of ltv350qv_power() through to ltv350qv_write_reg() is still less than 1k. Daniel.