From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 356F6C4363A for ; Wed, 28 Oct 2020 22:22:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7475F206D5 for ; Wed, 28 Oct 2020 22:22:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ONX0dYo1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7475F206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 94E2F6B005C; Wed, 28 Oct 2020 18:22:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FF476B0062; Wed, 28 Oct 2020 18:22:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C5946B0068; Wed, 28 Oct 2020 18:22:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0038.hostedemail.com [216.40.44.38]) by kanga.kvack.org (Postfix) with ESMTP id 50E3D6B005C for ; Wed, 28 Oct 2020 18:22:39 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DD605180AD817 for ; Wed, 28 Oct 2020 22:22:38 +0000 (UTC) X-FDA: 77422759596.30.floor29_1e0df6c27288 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id BEFE0180B3C8B for ; Wed, 28 Oct 2020 22:22:38 +0000 (UTC) X-HE-Tag: floor29_1e0df6c27288 X-Filterd-Recvd-Size: 3099 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf09.hostedemail.com (Postfix) with ESMTP for ; Wed, 28 Oct 2020 22:22:38 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A440320728; Wed, 28 Oct 2020 22:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603923757; bh=OmP6k00WFBwd/opJ4MplWHnkgdPh79U0SXiubjk+JcI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ONX0dYo1vbljR7qdg4w4JKfl6/4LaY4H0YR9U1tIV36Po4lo5MBNefvgZeH+8wSME XPma1JosmcvEJejEyQocTMXG3We4gikzL0Pnq0TVT/cLgjNhf6grR84hZuQgjsGBI8 SfEAEYF6P080TjeiHlKz4gqHh25Qc0AaQY2w/B6k= Date: Wed, 28 Oct 2020 15:22:35 -0700 From: Andrew Morton To: Matthew Wilcox Cc: linux-mm@kvack.org, axboe@kernel.dk, kent.overstreet@gmail.com Subject: Re: + fs-break-generic_file_buffered_read-up-into-multiple-functions.patch added to -mm tree Message-Id: <20201028152235.125172e46ae70ba4d7094469@linux-foundation.org> In-Reply-To: <20201027133551.GW20115@casper.infradead.org> References: <20201025220817.XxXVE%akpm@linux-foundation.org> <20201027133551.GW20115@casper.infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 27 Oct 2020 13:35:51 +0000 Matthew Wilcox wrote: > On Sun, Oct 25, 2020 at 03:08:17PM -0700, akpm@linux-foundation.org wrote: > > The patch titled > > Subject: mm/filemap/c: freak generic_file_buffered_read up into multiple functions > > has been added to the -mm tree. Its filename is > > fs-break-generic_file_buffered_read-up-into-multiple-functions.patch > > Can we back this out? It really makes the THP patchset unhappy. I think > we can do something like this afterwards, but doing it this way round is > ridiculously hard. Two concerns: : On my test box, 4k buffered random reads go from ~150k to ~250k iops, : and the improvements to big sequential reads are even bigger. That's a big improvement! We want that improvement. Throwing it away on behalf of an as-yet-unmerged feature patchset hurts. Can we expect that this improvement will be available post-that-patchset? And when? (This improvment is rather hard to believe, really - more details on the test environment would be useful. Can we expect that people will in general see similar benefits or was there something special about the testing?) Secondly, : This incorporates the fix for IOCB_WAITQ handling that Jens just : posted as well Is this (mysterious, unreferenced!) fix against v1 of Kent's patchset, or is it against mainline? If it's against mainline then it's presumably first priority. Can we please get that sent out in a standalone form asap?