* [PATCH] mm/process_vm_access: Add missing #include <linux/compat.h>
@ 2020-10-27 18:22 Geert Uytterhoeven
2020-10-27 19:33 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2020-10-27 18:22 UTC (permalink / raw)
To: Jens Axboe, Linus Torvalds
Cc: Al Viro, Christoph Hellwig, Andrew Morton, linux-mm, linux-kernel
With e.g. m68k/defconfig:
mm/process_vm_access.c: In function ‘process_vm_rw’:
mm/process_vm_access.c:277:5: error: implicit declaration of function ‘in_compat_syscall’ [-Werror=implicit-function-declaration]
277 | in_compat_syscall());
| ^~~~~~~~~~~~~~~~~
Fix this by adding #include <linux/compat.h>.
Reported-by: noreply@ellerman.id.au
Fixes: 38dc5079da7081e8 ("Fix compat regression in process_vm_rw()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
mm/process_vm_access.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c
index 05676722d9cd6afb..702250f148e73adc 100644
--- a/mm/process_vm_access.c
+++ b/mm/process_vm_access.c
@@ -5,6 +5,7 @@
* Copyright (C) 2010-2011 Christopher Yeoh <cyeoh@au1.ibm.com>, IBM Corp.
*/
+#include <linux/compat.h>
#include <linux/mm.h>
#include <linux/uio.h>
#include <linux/sched.h>
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mm/process_vm_access: Add missing #include <linux/compat.h>
2020-10-27 18:22 [PATCH] mm/process_vm_access: Add missing #include <linux/compat.h> Geert Uytterhoeven
@ 2020-10-27 19:33 ` Jens Axboe
2020-10-27 19:40 ` Linus Torvalds
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2020-10-27 19:33 UTC (permalink / raw)
To: Geert Uytterhoeven, Linus Torvalds
Cc: Al Viro, Christoph Hellwig, Andrew Morton, linux-mm, linux-kernel
On 10/27/20 12:22 PM, Geert Uytterhoeven wrote:
> With e.g. m68k/defconfig:
>
> mm/process_vm_access.c: In function ‘process_vm_rw’:
> mm/process_vm_access.c:277:5: error: implicit declaration of function ‘in_compat_syscall’ [-Werror=implicit-function-declaration]
> 277 | in_compat_syscall());
> | ^~~~~~~~~~~~~~~~~
>
> Fix this by adding #include <linux/compat.h>.
Oversight on my part, didn't fail on my configs. Linus, can you pick
this one up?
Acked-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/process_vm_access: Add missing #include <linux/compat.h>
2020-10-27 19:33 ` Jens Axboe
@ 2020-10-27 19:40 ` Linus Torvalds
0 siblings, 0 replies; 3+ messages in thread
From: Linus Torvalds @ 2020-10-27 19:40 UTC (permalink / raw)
To: Jens Axboe
Cc: Geert Uytterhoeven, Al Viro, Christoph Hellwig, Andrew Morton,
Linux-MM, Linux Kernel Mailing List
On Tue, Oct 27, 2020 at 12:33 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> Oversight on my part, didn't fail on my configs. Linus, can you pick
> this one up?
Done.
Linus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-27 19:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 18:22 [PATCH] mm/process_vm_access: Add missing #include <linux/compat.h> Geert Uytterhoeven
2020-10-27 19:33 ` Jens Axboe
2020-10-27 19:40 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox