From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92C8EC4363A for ; Mon, 26 Oct 2020 16:33:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C7A6D206FB for ; Mon, 26 Oct 2020 16:33:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="d7zo3iFs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7A6D206FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD8456B006E; Mon, 26 Oct 2020 12:33:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D89D16B0070; Mon, 26 Oct 2020 12:33:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C77AA6B0071; Mon, 26 Oct 2020 12:33:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 985376B006E for ; Mon, 26 Oct 2020 12:33:17 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 31274824999B for ; Mon, 26 Oct 2020 16:33:17 +0000 (UTC) X-FDA: 77414621634.16.dust73_5d0d2bc27274 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 17941100E691E for ; Mon, 26 Oct 2020 16:33:17 +0000 (UTC) X-HE-Tag: dust73_5d0d2bc27274 X-Filterd-Recvd-Size: 3822 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Mon, 26 Oct 2020 16:33:16 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id e6so7139667qtw.10 for ; Mon, 26 Oct 2020 09:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/aUvPW/gQptwPtNaMP+81vtynzWwIARk5FQTrQ0gwpc=; b=d7zo3iFsr5dB887LTWwmY7eG8bVck3YJeQu6GTRVm3Vcxg/i5jz8WsgZdiKUpkQoaL CLAleqhZPjmeSeY1iRBYYoaEiFIIrnX6RxKlwQE4XPkb/JE3Ljb2THi+Zn3+VlyMZL7n 3DwjEBqA1oiugmzqh+BAFJYcBwbLQbVGLty5/KNzvuD/3cdnubzQq75yDF/zYVciDZ32 1rT++6haZXKRI6VFXDcuu7ONY6xWWRbTsMhQwmzcV5Z/TESLBaWaR7IM7dt3RVRWLk9S 6Rg3oUX6wLuHoX2M4sus+osPNtEZnIwL8iXECTJ78fAyud3TGAErNG9mXNdjpPPiALNd uRxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/aUvPW/gQptwPtNaMP+81vtynzWwIARk5FQTrQ0gwpc=; b=Zj6BpCCqGeurvtTuPVrwaNVrlU0YBDV9isVrbS5oq8d8V1en7NtJnIqTCt3eYAu5v8 uFnDFJcoy5tsfDMDGLQgxC+o68hPyOj+R48dBccfrbaPoURg/5ruLGtgqDEV2LvOnNMT P76kL+S6k5TiaPUaUcZQKL7URww0r8PaddpgU0KMYxAqNA/A/lbxquiEG8JyOl0g1to1 yM6YmTu+Jhrli4blqOUmzMHA/4N/dFmUTaro1voyML0GfmU6MsumVOd9Nlw/CdLpExJF vifxnzj0vpCg06+Ys3kQBc9CMP0UfmqeDNljwt8NEyh6YcoCKZ1Xsrp9YqlL+shsxFN+ Msqg== X-Gm-Message-State: AOAM532U/6bvIgYiHSRQC73+shQP44dz207XblPYv3C2zeAPcnGi0rk3 OiEWlArM8309KFuNaQVmv34oHA== X-Google-Smtp-Source: ABdhPJzBNQIdhPmSl0GHIdNS93uaJK6N9TDKc1towz7MJwMmTvptEPOuHIm+LLw2PdfIgswyRa9+HA== X-Received: by 2002:aed:3323:: with SMTP id u32mr17599564qtd.355.1603729995628; Mon, 26 Oct 2020 09:33:15 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:be5c]) by smtp.gmail.com with ESMTPSA id t12sm6708464qkg.132.2020.10.26.09.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 09:33:14 -0700 (PDT) Date: Mon, 26 Oct 2020 12:31:33 -0400 From: Johannes Weiner To: Michal Hocko Cc: zhongjiang-ali , vdavydov.dev@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: memcontrol: correct the NR_ANON_THPS counter of hierarchical memcg Message-ID: <20201026163133.GB548555@cmpxchg.org> References: <1603722395-72443-1-git-send-email-zhongjiang-ali@linux.alibaba.com> <20201026144757.GJ20500@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201026144757.GJ20500@dhcp22.suse.cz> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 26, 2020 at 03:47:57PM +0100, Michal Hocko wrote: > On Mon 26-10-20 22:26:35, zhongjiang-ali wrote: > > memcg_page_state will get the specified number in hierarchical memcg, > > It should multiply by HPAGE_PMD_NR rather than an page if the item is > > NR_ANON_THPS. > > I am not sure which tree are you looking at but the current Linus tree > already does have this hunk. This tripped up my pattern matching as well. You go to the code and you see this bit already there. But it's only there for the local stats, not the hierarchical stats, and the code for them is nearly identical - except "%s" vs "total_%s" and memcg_page_state_local() vs memcg_page_state(). Zhongjiang is updating the hierarchical stats a few lines below where you see that hunk.