From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, PDS_TONAME_EQ_TOLOCAL_SHORT,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B17CEC4363A for ; Mon, 26 Oct 2020 14:49:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2516D22281 for ; Mon, 26 Oct 2020 14:49:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="cfa+86Ch" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2516D22281 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A8336B006C; Mon, 26 Oct 2020 10:49:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15A446B006E; Mon, 26 Oct 2020 10:49:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 097386B0070; Mon, 26 Oct 2020 10:49:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id D3B8A6B006C for ; Mon, 26 Oct 2020 10:49:02 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7564C181AC9CB for ; Mon, 26 Oct 2020 14:49:02 +0000 (UTC) X-FDA: 77414358924.11.cat74_3008d2227274 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 57819180F8B80 for ; Mon, 26 Oct 2020 14:49:02 +0000 (UTC) X-HE-Tag: cat74_3008d2227274 X-Filterd-Recvd-Size: 3438 Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Mon, 26 Oct 2020 14:49:01 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id h19so6848981qtq.4 for ; Mon, 26 Oct 2020 07:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zbEcoHWVRP/cOk4LGaeGy/eMcvb+AMQGJK26yVFzGZQ=; b=cfa+86ChZA6bU5VSTIH/OVr6fhqYF/7awplftBz1alDnx/+Bb/AqHHHOagXiuzIlMj 9g2pJDM+XXrIoj/U1IkJBTAa1o0jrE1wmgemIGnl+144F/6Vmjp9v9F2z5Ssny1ytaBO 9MtztQTNdL0Mx0cQ/ETa4zpxcAgg5Oye7RbEc4fgfqT1/+cUY0qiuSbeeoswbT0UhUq0 rCj2Y8TLWoDLBZmeuI8N354gF6yh3BHXM255XYL7m3nL8a6P8XNt4kGJ0WokiM9jMTHL 2agUgkMVwVmAmBpehKy4Zq80ct+8GsX6t8h3HJk5rDQt7G4KQdUhPSqo3Vz65BsTCYLF UG8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zbEcoHWVRP/cOk4LGaeGy/eMcvb+AMQGJK26yVFzGZQ=; b=q0LSwPvx1J7r6BA9NFMu1qgmfEPfAl6IpA1oOG5smLpLWd3AP9w7TISx+nUuEfaMyp FqfmoeCiJ6ifPHwfp12+rLrrH5TWRFtMVNJUu2pBOcyW06H7QKAgrA3lUg4G/OFoELAF CJ/p4/0IxmhhqsBtqp5MJbQSL06vnwbod7hve8hxse5yCE4aUO6tX5GrKV1uuSdyhtAG zHFWFwfHl/egcohKK/PzZPN3uG/iI/lfesyX2qkfixCrH4r2tt8GYcaxXmJGRMbyBSQb A6itLKwNktcWGKusoB96qoDJKx22C7nntJNtd/bKyB5aSH5nnLVikwotY8wV/Ea/Wt2O kOMg== X-Gm-Message-State: AOAM533e0rI1ulLOPObzlCk8gsQFbjXeyrkMvxNDju3HiRhPd0I+YDC+ WNiv5kahdcsgIfjlG9h3BIxDHg== X-Google-Smtp-Source: ABdhPJwUg9PT093mpSxrFfAawlG1TREt6mjQFNAu7wLZq0qi3WflFNHg86ZqPR7XE5Oy6Oj3QPOorA== X-Received: by 2002:ac8:4d92:: with SMTP id a18mr17849058qtw.338.1603723741064; Mon, 26 Oct 2020 07:49:01 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:be5c]) by smtp.gmail.com with ESMTPSA id 6sm6525372qtz.31.2020.10.26.07.48.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 07:49:00 -0700 (PDT) Date: Mon, 26 Oct 2020 10:47:19 -0400 From: Johannes Weiner To: zhongjiang-ali Cc: mhocko@kernel.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: memcontrol: correct the NR_ANON_THPS counter of hierarchical memcg Message-ID: <20201026144719.GA548555@cmpxchg.org> References: <1603722395-72443-1-git-send-email-zhongjiang-ali@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603722395-72443-1-git-send-email-zhongjiang-ali@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 26, 2020 at 10:26:35PM +0800, zhongjiang-ali wrote: > memcg_page_state will get the specified number in hierarchical memcg, > It should multiply by HPAGE_PMD_NR rather than an page if the item is > NR_ANON_THPS. > > Fixes: 468c398233da ("mm: memcontrol: switch to native NR_ANON_THPS counter") > Signed-off-by: zhongjiang-ali Acked-by: Johannes Weiner