From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528C5C433DF for ; Fri, 16 Oct 2020 17:26:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9051621582 for ; Fri, 16 Oct 2020 17:26:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="cvs1EqQJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9051621582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BE742900002; Fri, 16 Oct 2020 13:26:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B97846B0071; Fri, 16 Oct 2020 13:26:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A860B900002; Fri, 16 Oct 2020 13:26:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id 7B0BF6B006E for ; Fri, 16 Oct 2020 13:26:39 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 19CA4180AD807 for ; Fri, 16 Oct 2020 17:26:39 +0000 (UTC) X-FDA: 77378468118.02.beds91_1407c492721e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id E96EF100FD67D for ; Fri, 16 Oct 2020 17:26:38 +0000 (UTC) X-HE-Tag: beds91_1407c492721e X-Filterd-Recvd-Size: 3629 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Fri, 16 Oct 2020 17:26:38 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1602869197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S7adOyJQobTs7oFN7R41/ee6ZODNptFcC0aLMfk4q+Q=; b=cvs1EqQJad6ys0IgBRtNq+qkk7IAGgPYw8pc+utGMKssl6HaCS8gQoJoBHSjjuuEmU1ksy Ds1TvB9F1dI6TZbBH9+Ek+woExdQtDWvp9GT5QRl0QoCdLF2WHvKMhuVxJucc50i5/U3+M k/KNwdhcwmKXqSKlzi+r3bAGjhwnk5k= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 29212AC19; Fri, 16 Oct 2020 17:26:37 +0000 (UTC) Date: Fri, 16 Oct 2020 19:26:35 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Richard Palethorpe Cc: Roman Gushchin , ltp@lists.linux.it, Johannes Weiner , Andrew Morton , Shakeel Butt , Christoph Lameter , Michal Hocko , Tejun Heo , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mm: memcg/slab: Stop reparented obj_cgroups from charging root Message-ID: <20201016172635.GB102311@blackbook> References: <20201014190749.24607-1-rpalethorpe@suse.com> <20201016094702.GA95052@blackbook> <87sgaesba0.fsf@suse.de> <87pn5irz2m.fsf@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xgyAXRrhYN0wYx8y" Content-Disposition: inline In-Reply-To: <87pn5irz2m.fsf@suse.de> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --xgyAXRrhYN0wYx8y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 16, 2020 at 04:05:21PM +0100, Richard Palethorpe wrote: > I'm don't know if that could happen without reparenting. I suppose if > use_hierarchy=1 then actually this patch will result in root being > overcharged, so perhaps it should also check for use_hierarchy? Right, you'd need to distinguish whether the uncharged objcg was originally (not)charged in the root memcg or it was only reparented to it. (I originally considered only the genuine root objcgs.) In this light, homogenous charing to root memcg looks really simpler but I wonder what other surprises it brings about. Michal --xgyAXRrhYN0wYx8y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEEoQaUCWq8F2Id1tNia1+riC5qSgFAl+J18cACgkQia1+riC5 qSgBlA/9E7AebKZQjQP9HUGpWS+49sRCns58CiQJhFugbkHlJl5PsgvI9rQs9j6k AhG6e0WZlMb35II+naqx3kNnAYoRiw8xWcuAH+lvWFXKI1saYN4UOjKNzigojTw0 x3fi9bRJveQtpwPY6IwXbiOJkYZnEplEskwiqbY0kCFZMhQlvnBfJIAzegEa5Jty ZCcqYPMxcfczsm3+vtrcHDWBXzujoxp9QPyyNWmRAkIjgTebO3ZmGRieCVmuPTm7 PY1nCA/65amYSsxBPvo+L7U5a4jKOV04pSLg0PeBByJbiy3TEoLi0938arMVg7P5 MT2PdqfzJ5W1T+7zh1SsRWV2/7b05JLVHnLPTL3SlvNIn2GIouSWSnAbdiZvqenB XFafC+4PbL0xTdo5Lrp3pqTgw8kwScNUz/5FnRAdNw7eET2bGRQ46ah3EBQsoqNw kOv07/gipMp3BBNJy6JHV+hSwK8CfOvy45FuyIJ6TAzYKZdOaBVWv4kt2eesHj+I qzGRmmhS1rPcSzMtZU2rBIXcWfy7tgUsPdyEOgx+0VE10O0Vn0qFEWcupTSLYykv 8C301Q+aMnXbFcytJ5dSixD3oxzI5OP3x8VIkyuuoFe9MsRJZuBwBAYS6Vl+Wwd4 fmJBhroGerid+YzHDvvB0zeNr+j4IBjztGGJznC0/Mgm/Bf3rn8= =j9PI -----END PGP SIGNATURE----- --xgyAXRrhYN0wYx8y--