From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C76F9C43457 for ; Fri, 16 Oct 2020 16:13:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 042AF20866 for ; Fri, 16 Oct 2020 16:13:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="jYFxSj0G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 042AF20866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8B27994000A; Fri, 16 Oct 2020 12:13:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 88873940007; Fri, 16 Oct 2020 12:13:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C44F94000A; Fri, 16 Oct 2020 12:13:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id DC604940007 for ; Fri, 16 Oct 2020 12:13:24 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D7A051EF1 for ; Fri, 16 Oct 2020 16:13:23 +0000 (UTC) X-FDA: 77378283486.15.front34_13018002721e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id B18051814B0C8 for ; Fri, 16 Oct 2020 16:13:23 +0000 (UTC) X-HE-Tag: front34_13018002721e X-Filterd-Recvd-Size: 4709 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Fri, 16 Oct 2020 16:13:23 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id u19so4553464ion.3 for ; Fri, 16 Oct 2020 09:13:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=SzfzkDBitQIi0dWl8hQ69VYetsUqJh1EpiO/PjfBVJ4=; b=jYFxSj0G8MEyNA6azgjTlI3p9WfsDHDEmQs6T3SvBZ2nPAHKqlNsKge/SQ531tHmcc AKcp/SO2BB1Fkw4uqOgO4xPcvAuls/is8lUdMvYQC/f3NKFiu0nmtm+Bn/y3IMI27SdB EVv/SiDOsylMgzjjUSuVh2dBkVf+OTtUjnLp3EDWRYIFPsNAVbZ7XEPR1ge5yEo9tPvw 1/WhhUZywzgh4WCtd9LFge+gy+I3UA6EWus/7VeckFhN9Wh36+DPxt+JU+rla7OrDvof UEOc4BTCnqfvCbZ6fIrXvMvG72jUwxm1v/fpGdA22meHccsaDiS5CqNvbuhFAWPV/aO9 7jZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=SzfzkDBitQIi0dWl8hQ69VYetsUqJh1EpiO/PjfBVJ4=; b=hdDs8sL+x99lDYEOgnJNxrHNYkNHZ833b9hjZRQ2tipVNAZ+XoJRcAyScDWIwM0BzH brKIfHfRGw1Plidy/9QnmN9DgY6ImSVB3DmODhjFxXU5+muCQIXhx09Pziq69c1SxxjT E90DW/f5lvOAcev05zB4MMopMr7eMlQ/dhMqghs+rHwx6rN+e2WMoD5KHgx9esWEjHf/ 6YH+8c98ZbvUdlxbGIn66t849fQ/+NFLlhbjmZM6ql4Ih3mJQpwPbVysWKR1rddPmElR ercy1+mwaXGj+B3Fj/lINAcibBtkd01ITMxFAoBHW1GvBLp3Z+yEs2xjOEVZc3jnOQln DmYw== X-Gm-Message-State: AOAM532qEEoUQoTw9yqfSKTTdn0J08CEcrBeTK6k0KVT9WQ3jGGbyjT5 /EUvKj4cnWb4ygiNgIXdnJi40nHuhAZFcA== X-Google-Smtp-Source: ABdhPJzTc2rLvv4IerCZW/tHbEy8NKIi/ATblrGysyjzLvEYe0ppftMeHbv9aVUT0VxOy6SpaKvMQQ== X-Received: by 2002:a02:b80f:: with SMTP id o15mr3153369jam.103.1602864802734; Fri, 16 Oct 2020 09:13:22 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id g17sm2378255ilq.15.2020.10.16.09.13.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Oct 2020 09:13:22 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kTSM5-000edC-4i; Fri, 16 Oct 2020 13:13:21 -0300 Date: Fri, 16 Oct 2020 13:13:21 -0300 From: Jason Gunthorpe To: Christian =?utf-8?B?S8O2bmln?= Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, chris@chris-wilson.co.uk, airlied@redhat.com, daniel@ffwll.ch, sumit.semwal@linaro.org, willy@infradead.org, jhubbard@nvidia.com, linmiaohe@huawei.com Subject: Re: [PATCH 2/2] mm: introduce vma_set_file function v4 Message-ID: <20201016161321.GF36674@ziepe.ca> References: <20201012085203.56119-1-christian.koenig@amd.com> <20201012085203.56119-2-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201012085203.56119-2-christian.koenig@amd.com> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 12, 2020 at 10:52:03AM +0200, Christian K=C3=B6nig wrote: > Add the new vma_set_file() function to allow changing > vma->vm_file with the necessary refcount dance. >=20 > v2: add more users of this. > v3: add missing EXPORT_SYMBOL, rebase on mmap cleanup, > add comments why we drop the reference on two occasions. > v4: make it clear that changing an anonymous vma is illegal. >=20 > Signed-off-by: Christian K=C3=B6nig > Reviewed-by: Daniel Vetter (v2) > --- > drivers/dma-buf/dma-buf.c | 3 +-- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 4 +--- > drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 3 +-- > drivers/gpu/drm/i915/gem/i915_gem_mman.c | 5 +++-- > drivers/gpu/drm/msm/msm_gem.c | 4 +--- > drivers/gpu/drm/omapdrm/omap_gem.c | 3 +-- > drivers/gpu/drm/vgem/vgem_drv.c | 3 +-- > drivers/staging/android/ashmem.c | 6 +++--- > include/linux/mm.h | 2 ++ > mm/mmap.c | 12 ++++++++++++ > 10 files changed, 26 insertions(+), 19 deletions(-) Reviewed-by: Jason Gunthorpe Jason