From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79D68C433DF for ; Fri, 16 Oct 2020 11:14:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D711720FC3 for ; Fri, 16 Oct 2020 11:14:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="fuiGsg5O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D711720FC3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 07799940008; Fri, 16 Oct 2020 07:14:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 027F8940007; Fri, 16 Oct 2020 07:14:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E313D940008; Fri, 16 Oct 2020 07:14:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id C9777940007 for ; Fri, 16 Oct 2020 07:14:41 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 81CEF1EE6 for ; Fri, 16 Oct 2020 11:14:41 +0000 (UTC) X-FDA: 77377530762.11.sun09_5d168472721c Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 5DBEB180F8B81 for ; Fri, 16 Oct 2020 11:14:41 +0000 (UTC) X-HE-Tag: sun09_5d168472721c X-Filterd-Recvd-Size: 3449 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Fri, 16 Oct 2020 11:14:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=eN4dhdp7jM9Nxf2wtHbF3iaybS5VG3Hx1LgyRbC/dwo=; b=fuiGsg5OoeoeWiS795FBcdosIT /JDvO7HIkVYc+EgZP3mGGZM1lxPJCwBxDzXfGGfxZBMtRcN0f9HK7Nk47ZxXkNVBubznUbIxuUFJe sgz0DF6i/emr1SZrKg4JHQTJBX2l10Lh/Xfvt9Tqc6bTAAQfTuQbkbg3DBus2vh80DZJiwGWQzQ4j gz8DuEPzsdQjLrOP8k7KcrMu59tFuHCs4lbHhz5M4lArv0WQwSgTZzS8RkXalh697oQgmf8zDWYRh wggP80kGVmmuxJYf9RSqJfFjnVYeSe5FOoqwH2/6X1k5yNkagaIeIINmkJSHHIblaq6dRvaHXcO+9 Z6ywiKTg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kTNgw-00039g-W6; Fri, 16 Oct 2020 11:14:35 +0000 Date: Fri, 16 Oct 2020 12:14:34 +0100 From: Matthew Wilcox To: Andrew Morton Cc: kirill.shutemov@linux.intel.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, sjpark@amazon.de, torvalds@linux-foundation.org, ying.huang@intel.com Subject: Re: [patch 021/156] mm/page_owner: change split_page_owner to take a count Message-ID: <20201016111434.GD20115@casper.infradead.org> References: <20201015192732.f448da14e9854c7cb7299956@linux-foundation.org> <20201016024210.g2-PNM3OR%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201016024210.g2-PNM3OR%akpm@linux-foundation.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 15, 2020 at 07:42:10PM -0700, Andrew Morton wrote: > From: "Matthew Wilcox (Oracle)" > Subject: mm/page_owner: change split_page_owner to take a count > > The implementation of split_page_owner() prefers a count rather than the > old order of the page. When we support a variable size THP, we won't > have the order at this point, but we will have the number of pages. > So change the interface to what the caller and callee would prefer. > > Link: https://lkml.kernel.org/r/20200908195539.25896-4-willy@infradead.org > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Kirill A. Shutemov > Reviewed-by: SeongJae Park > Cc: Huang Ying > Signed-off-by: Andrew Morton > --- This patch is missing this fix. My apologies. >From 93abfc1e81a1c96e4603766ea33308b74b221a30 Mon Sep 17 00:00:00 2001 From: "Matthew Wilcox (Oracle)" Date: Sat, 10 Oct 2020 11:19:05 -0400 Subject: [PATCH] mm: Fix call to split_page_owner Missed this call. Signed-off-by: Matthew Wilcox (Oracle) --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 780c8f023b28..763bbcec65b7 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3209,7 +3209,7 @@ void split_page(struct page *page, unsigned int order) for (i = 1; i < (1 << order); i++) set_page_refcounted(page + i); - split_page_owner(page, order); + split_page_owner(page, 1 << order); } EXPORT_SYMBOL_GPL(split_page); -- 2.28.0