From: Xianting Tian <tian.xianting@h3c.com>
To: <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
Xianting Tian <tian.xianting@h3c.com>
Subject: [PATCH] mm: vmscan: avoid a unnecessary reschedule in shrink_slab()
Date: Fri, 16 Oct 2020 11:39:52 +0800 [thread overview]
Message-ID: <20201016033952.1924-1-tian.xianting@h3c.com> (raw)
In shrink_slab(), it directly goes to 'out' label only when it
can't get the lock of shrinker_rwsew. In this case, it doesn't
do the real work of shrinking slab, so we don't need trigger a
reschedule by cond_resched().
Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
---
mm/vmscan.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 466fc3144..676e97b28 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -687,8 +687,9 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
}
up_read(&shrinker_rwsem);
-out:
+
cond_resched();
+out:
return freed;
}
--
2.17.1
next reply other threads:[~2020-10-16 3:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 3:39 Xianting Tian [this message]
2020-10-16 12:07 ` Michal Hocko
2020-10-16 12:48 ` Tianxianting
2020-10-16 13:02 ` Michal Hocko
2020-10-16 13:20 ` Tianxianting
2020-10-16 13:44 ` Michal Hocko
2020-10-16 14:33 ` Tianxianting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016033952.1924-1-tian.xianting@h3c.com \
--to=tian.xianting@h3c.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox