From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4914AC433DF for ; Fri, 16 Oct 2020 02:48:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA3302074D for ; Fri, 16 Oct 2020 02:48:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="P3Fo3hUa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA3302074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 55B4F94005D; Thu, 15 Oct 2020 22:48:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5099D940034; Thu, 15 Oct 2020 22:48:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FA2794005D; Thu, 15 Oct 2020 22:48:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0033.hostedemail.com [216.40.44.33]) by kanga.kvack.org (Postfix) with ESMTP id 09EAF940034 for ; Thu, 15 Oct 2020 22:48:35 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id AC1D61EE6 for ; Fri, 16 Oct 2020 02:48:35 +0000 (UTC) X-FDA: 77376255390.08.tank22_4d029ea27219 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 883761819E766 for ; Fri, 16 Oct 2020 02:48:35 +0000 (UTC) X-HE-Tag: tank22_4d029ea27219 X-Filterd-Recvd-Size: 2304 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Fri, 16 Oct 2020 02:48:35 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E45882087D; Fri, 16 Oct 2020 02:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602816514; bh=1p2WGIZu9/zLv2jaihLdekpGlwjlNasd31lW4kWG3Hk=; h=Date:From:To:Subject:In-Reply-To:From; b=P3Fo3hUaaYavzqlzgEJbOpOslFNX7vnbcgj1hgXSBZthGPTsuLpqLkLdGQ+5OdqBO wE0nXFKZiaEwbmVvle2bM3mQ73chbnovXwB9U+rHkjE3n6un8tnt+HRMjBJ7069zFn C/Iv1qPQaknPruDvkLALowS14hQJ69pizYx8CnAQ= Date: Thu, 15 Oct 2020 19:48:33 -0700 From: Andrew Morton To: akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com, christian.brauner@ubuntu.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, richard.weiyang@linux.alibaba.com, torvalds@linux-foundation.org Subject: [patch 119/156] bitops: simplify get_count_order_long() Message-ID: <20201016024833._HHE9Nf8E%akpm@linux-foundation.org> In-Reply-To: <20201015192732.f448da14e9854c7cb7299956@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Wei Yang Subject: bitops: simplify get_count_order_long() These two cases could be unified into one. Link: https://lkml.kernel.org/r/20200807085837.11697-2-richard.weiyang@linux.alibaba.com Signed-off-by: Wei Yang Cc: Christian Brauner Cc: Andy Shevchenko Signed-off-by: Andrew Morton --- include/linux/bitops.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/include/linux/bitops.h~bitops-simplify-get_count_order_long +++ a/include/linux/bitops.h @@ -206,10 +206,7 @@ static inline int get_count_order_long(u { if (l == 0UL) return -1; - else if (l & (l - 1UL)) - return (int)fls_long(l); - else - return (int)fls_long(l) - 1; + return (int)fls_long(--l); } /** _