From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E09F1C43457 for ; Fri, 16 Oct 2020 02:48:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6998220897 for ; Fri, 16 Oct 2020 02:48:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="v3OZIyo9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6998220897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 078EA94005C; Thu, 15 Oct 2020 22:48:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0016C940034; Thu, 15 Oct 2020 22:48:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0C9694005C; Thu, 15 Oct 2020 22:48:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0245.hostedemail.com [216.40.44.245]) by kanga.kvack.org (Postfix) with ESMTP id AD975940034 for ; Thu, 15 Oct 2020 22:48:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4DF153623 for ; Fri, 16 Oct 2020 02:48:32 +0000 (UTC) X-FDA: 77376255264.30.glove02_0d06c4927219 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 2C488180B3AA7 for ; Fri, 16 Oct 2020 02:48:32 +0000 (UTC) X-HE-Tag: glove02_0d06c4927219 X-Filterd-Recvd-Size: 2613 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Fri, 16 Oct 2020 02:48:31 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E1B3208E4; Fri, 16 Oct 2020 02:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602816511; bh=ZYjvwyI/eUwAgTG97KnHQSZMik8xQcTqfc6qJ2GjU1k=; h=Date:From:To:Subject:In-Reply-To:From; b=v3OZIyo97KgwEsiyN+gT1hU6pnoPXzQ4G92k5ex8u4+P0eRB5E/00jtAjiUx68VJy IkE3l1k5UYFmmrcF9FmDTb2JjB07QV6kXXl8giaJaeGqEzdF+c7pdbrme/iiL5hE1Z vA7Ri6zI0ItjpBlz6cl59zGPe8pUWam6HI9GR7KM= Date: Thu, 15 Oct 2020 19:48:30 -0700 From: Andrew Morton To: akpm@linux-foundation.org, corbet@lwn.net, kernel@cdqe.de, krzk@kernel.org, linux-mm@kvack.org, mchehab+huawei@kernel.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 118/156] lib/crc32.c: fix trivial typo in preprocessor condition Message-ID: <20201016024830.ZQ9_xyLez%akpm@linux-foundation.org> In-Reply-To: <20201015192732.f448da14e9854c7cb7299956@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Tobias Jordan Subject: lib/crc32.c: fix trivial typo in preprocessor condition Whether crc32_be needs a lookup table is chosen based on CRC_LE_BITS. Obviously, the _be function should be governed by the _BE_ define. This probably never pops up as it's hard to come up with a configuration where CRC_BE_BITS isn't the same as CRC_LE_BITS and as nobody is using bitwise CRC anyway. Link: https://lkml.kernel.org/r/20200923182122.GA3338@agrajag.zerfleddert.de Fixes: 46c5801eaf86 ("crc32: bolt on crc32c") Signed-off-by: Tobias Jordan Cc: Krzysztof Kozlowski Cc: Jonathan Corbet Cc: Mauro Carvalho Chehab Signed-off-by: Andrew Morton --- lib/crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/crc32.c~lib-crc32c-fix-trivial-typo-in-preprocessor-condition +++ a/lib/crc32.c @@ -331,7 +331,7 @@ static inline u32 __pure crc32_be_generi return crc; } -#if CRC_LE_BITS == 1 +#if CRC_BE_BITS == 1 u32 __pure crc32_be(u32 crc, unsigned char const *p, size_t len) { return crc32_be_generic(crc, p, len, NULL, CRC32_POLY_BE); _