From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A49AC43467 for ; Fri, 16 Oct 2020 02:48:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 293472074D for ; Fri, 16 Oct 2020 02:48:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bd2210KJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 293472074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B751294005B; Thu, 15 Oct 2020 22:48:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFD87940034; Thu, 15 Oct 2020 22:48:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EDAC94005B; Thu, 15 Oct 2020 22:48:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 6EE95940034 for ; Thu, 15 Oct 2020 22:48:29 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 052458249980 for ; Fri, 16 Oct 2020 02:48:29 +0000 (UTC) X-FDA: 77376255138.29.talk06_0d0396327219 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id D6FF818086CDD for ; Fri, 16 Oct 2020 02:48:28 +0000 (UTC) X-HE-Tag: talk06_0d0396327219 X-Filterd-Recvd-Size: 2585 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 16 Oct 2020 02:48:28 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FD9E216C4; Fri, 16 Oct 2020 02:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602816507; bh=tkkofZ7qD82CsOvPieJHBNYt4OyOhg5WwZnbkEnr6T8=; h=Date:From:To:Subject:In-Reply-To:From; b=Bd2210KJUHtCtsk3uxFhiNBLTIl/ta11PhBdWGU9g1Bwz+7adxBr+4v68h/xnjKY3 G7E40+5wkyPR61uNrpvy4QNA4apJFW78Cp2jHeSins2gZPDGPSPAiHPQzTbPPpPUn2 g6UiuUHYkc71PF/dR3Lsj3Gm8Y5UJSKCzPM9P1oI= Date: Thu, 15 Oct 2020 19:48:26 -0700 From: Andrew Morton To: akpm@linux-foundation.org, dan.carpenter@oracle.com, dan.j.williams@intel.com, jgg@ziepe.ca, jglisse@redhat.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, rcampbell@nvidia.com, sfr@canb.auug.org.au, torvalds@linux-foundation.org Subject: [patch 117/156] lib/test_hmm.c: fix an error code in dmirror_allocate_chunk() Message-ID: <20201016024826.10tNs0-zo%akpm@linux-foundation.org> In-Reply-To: <20201015192732.f448da14e9854c7cb7299956@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Dan Carpenter Subject: lib/test_hmm.c: fix an error code in dmirror_allocate_chunk() This is supposed to return false on failure, not a negative error code. Link: https://lkml.kernel.org/r/20201010200812.GA1886610@mwanda Fixes: 170e38548b81 ("mm/hmm/test: use after free in dmirror_allocate_chunk()") Signed-off-by: Dan Carpenter Reviewed-by: Ralph Campbell Cc: Jerome Glisse Cc: Stephen Rothwell Cc: Jason Gunthorpe Cc: Dan Williams Signed-off-by: Andrew Morton --- lib/test_hmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/test_hmm.c~mm-hmm-test-fix-an-error-code-in-dmirror_allocate_chunk +++ a/lib/test_hmm.c @@ -461,7 +461,7 @@ static bool dmirror_allocate_chunk(struc devmem = kzalloc(sizeof(*devmem), GFP_KERNEL); if (!devmem) - return -ENOMEM; + return false; res = request_free_mem_region(&iomem_resource, DEVMEM_CHUNK_SIZE, "hmm_dmirror"); _