From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886CFC433E7 for ; Wed, 14 Oct 2020 17:26:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA1842173E for ; Wed, 14 Oct 2020 17:26:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Hid3+8Vu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA1842173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2102D6B0062; Wed, 14 Oct 2020 13:26:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BF9B6B0068; Wed, 14 Oct 2020 13:26:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AFB76B006E; Wed, 14 Oct 2020 13:26:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id D1A686B0062 for ; Wed, 14 Oct 2020 13:26:38 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 55221181AC9C6 for ; Wed, 14 Oct 2020 17:26:38 +0000 (UTC) X-FDA: 77371210476.19.smoke04_37178cc2720d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 273701ACEA2 for ; Wed, 14 Oct 2020 17:26:38 +0000 (UTC) X-HE-Tag: smoke04_37178cc2720d X-Filterd-Recvd-Size: 2118 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Wed, 14 Oct 2020 17:26:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wZo7ZkSSpcEOkwiGEswMZXQPiQFGCWMDlHQwEWZTg+g=; b=Hid3+8VuqwReQUUypNu3kZeRe2 Kh2KAmXxKY9Ur8nD/slUpFfahtVHNvwKhZdE3S5k7mf0fCXYvZ6ZI1rbbYDJhD1DJH+YMdOS27CEn cS6ALVl8MxmDkVlWkBRCt16Q8QFwmAZXLmKs7hb2+QBs5Zb1OU1sBuVaXnXORj7m4tnxDGryqLWRR /qbjCcKQ+zTqUuSu968Cc6Pt8vBxgdBjE78qVUsrM7zOfljDPz5hTFWvIOnSWsyxniwL89WQJLzBC 7CLrKfQKHqoLWw/hm24cq12IcO/GnTC5j5s+mi1CzN6slefAFm+vRZvpzdbBnaWlnn/DW/BwDRUf4 ORjZoMvg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSkXq-0004pT-Vr; Wed, 14 Oct 2020 17:26:35 +0000 Date: Wed, 14 Oct 2020 18:26:34 +0100 From: Matthew Wilcox To: "Darrick J. Wong" Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/14] iomap: Support THPs in invalidatepage Message-ID: <20201014172634.GP20115@casper.infradead.org> References: <20201014030357.21898-1-willy@infradead.org> <20201014030357.21898-6-willy@infradead.org> <20201014163347.GI9832@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201014163347.GI9832@magnolia> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 14, 2020 at 09:33:47AM -0700, Darrick J. Wong wrote: > > @@ -1415,7 +1420,6 @@ iomap_writepage_map(struct iomap_writepage_ctx *wpc, > > */ > > if (wpc->ops->discard_page) > > wpc->ops->discard_page(page); > > - ClearPageUptodate(page); > > Er, I don't get it -- why do we now leave the page up to date after > writeback fails? The page is still uptodate -- every byte in this page is at least as new as the corresponding bytes on disk.