From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A85C4C43457 for ; Tue, 13 Oct 2020 23:58:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5D3B32222F for ; Tue, 13 Oct 2020 23:58:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LIPppHOW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D3B32222F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EF68294002A; Tue, 13 Oct 2020 19:58:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E80C8940012; Tue, 13 Oct 2020 19:58:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D95BB94002A; Tue, 13 Oct 2020 19:58:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id A4CE3940012 for ; Tue, 13 Oct 2020 19:58:41 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4D2B48249980 for ; Tue, 13 Oct 2020 23:58:41 +0000 (UTC) X-FDA: 77368569642.10.cars85_0d01d3527207 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 24AF516A0D1 for ; Tue, 13 Oct 2020 23:58:41 +0000 (UTC) X-HE-Tag: cars85_0d01d3527207 X-Filterd-Recvd-Size: 2406 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 23:58:40 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB4D122244; Tue, 13 Oct 2020 23:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602633520; bh=uLMJqaG2fSzmDqcISfOMh5TCXCS4J0HwSuFKKKnjR74=; h=Date:From:To:Subject:In-Reply-To:From; b=LIPppHOW03glEGggRm427zlbw0G3r4tOQ1BIltRzL/q6nCMBJm3JzTkFJhvZY1Akb v9FCW8UD/LlHW/RBfwXlaqcS06rfOL84qRP9pD+9Tj4W6JdZl2GIJ6oSfA7x3AmENJ RxlCw0gfjPBWb+7qPucuTvmQJiH1PPDcPrwdu7V4= Date: Tue, 13 Oct 2020 16:58:39 -0700 From: Andrew Morton To: akpm@linux-foundation.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com, jhubbard@nvidia.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, rcampbell@nvidia.com, torvalds@linux-foundation.org Subject: [patch 180/181] mm/migrate: remove cpages-- in migrate_vma_finalize() Message-ID: <20201013235839.lCcrWFxQM%akpm@linux-foundation.org> In-Reply-To: <20201013164658.3bfd96cc224d8923e66a9f4e@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Ralph Campbell Subject: mm/migrate: remove cpages-- in migrate_vma_finalize() The variable struct migrate_vma->cpages is only used in migrate_vma_setup(). There is no need to decrement it in migrate_vma_finalize() since it is never checked. Link: http://lkml.kernel.org/r/20200827190735.12752-1-rcampbell@nvidia.com Signed-off-by: Ralph Campbell Cc: Jason Gunthorpe Cc: Jerome Glisse Cc: John Hubbard Cc: Christoph Hellwig Signed-off-by: Andrew Morton --- mm/migrate.c | 1 - 1 file changed, 1 deletion(-) --- a/mm/migrate.c~mm-migrate-remove-cpages-in-migrate_vma_finalize +++ a/mm/migrate.c @@ -3077,7 +3077,6 @@ void migrate_vma_finalize(struct migrate remove_migration_ptes(page, newpage, false); unlock_page(page); - migrate->cpages--; if (is_zone_device_page(page)) put_page(page); _