From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BEF1C433DF for ; Tue, 13 Oct 2020 23:48:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE63A21D81 for ; Tue, 13 Oct 2020 23:48:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="FbNdQDMx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE63A21D81 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 944856B0087; Tue, 13 Oct 2020 19:48:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91B216B0088; Tue, 13 Oct 2020 19:48:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E3F06B0089; Tue, 13 Oct 2020 19:48:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 4F83E6B0087 for ; Tue, 13 Oct 2020 19:48:46 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E65391EE6 for ; Tue, 13 Oct 2020 23:48:45 +0000 (UTC) X-FDA: 77368544610.21.kiss72_201419227207 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id C9523180442C4 for ; Tue, 13 Oct 2020 23:48:45 +0000 (UTC) X-HE-Tag: kiss72_201419227207 X-Filterd-Recvd-Size: 2735 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 23:48:45 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4FBC122227; Tue, 13 Oct 2020 23:48:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602632924; bh=ZWqsrRLAvjyJLHfAhm5VYkHoyqW9PWHkfxq4EaTFIcw=; h=Date:From:To:Subject:In-Reply-To:From; b=FbNdQDMxTns3ZpoLaDvG/D2MegtMjm3QTC26OgZNLu1FS3dz78wSeF0HQCuMfQKXg 8w5gq5lU+joLDMKZJau8zDmZrj4dyRKQvSVkNTOROM1b0W0QF78egn5ywxRtbZSyAs 3kpc/A6fs+X+cO5ByA2q58Bj/YPdheM9A7egMS1w= Date: Tue, 13 Oct 2020 16:48:43 -0700 From: Andrew Morton To: akpm@linux-foundation.org, cl@linux.com, hewenliang4@huawei.com, hushiyuan@huawei.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, penberg@kernel.org, rientjes@google.com, torvalds@linux-foundation.org, wuyun.wu@huawei.com Subject: [patch 022/181] mm/slub: fix missing ALLOC_SLOWPATH stat when bulk alloc Message-ID: <20201013234843.Wq-xPj29u%akpm@linux-foundation.org> In-Reply-To: <20201013164658.3bfd96cc224d8923e66a9f4e@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Abel Wu Subject: mm/slub: fix missing ALLOC_SLOWPATH stat when bulk alloc The ALLOC_SLOWPATH statistics is missing in bulk allocation now. Fix it by doing statistics in alloc slow path. Link: http://lkml.kernel.org/r/20200811022427.1363-1-wuyun.wu@huawei.com Signed-off-by: Abel Wu Reviewed-by: Pekka Enberg Acked-by: David Rientjes Cc: Christoph Lameter Cc: Joonsoo Kim Cc: Hewenliang Cc: Hu Shiyuan Signed-off-by: Andrew Morton --- mm/slub.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/mm/slub.c~mm-slub-fix-missing-alloc_slowpath-stat-when-bulk-alloc +++ a/mm/slub.c @@ -2661,6 +2661,8 @@ static void *___slab_alloc(struct kmem_c void *freelist; struct page *page; + stat(s, ALLOC_SLOWPATH); + page = c->page; if (!page) { /* @@ -2850,7 +2852,6 @@ redo: page = c->page; if (unlikely(!object || !node_match(page, node))) { object = __slab_alloc(s, gfpflags, node, addr, c); - stat(s, ALLOC_SLOWPATH); } else { void *next_object = get_freepointer_safe(s, object); _