From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914F2C433DF for ; Tue, 13 Oct 2020 23:48:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 410B422201 for ; Tue, 13 Oct 2020 23:48:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="GiTkMcU+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 410B422201 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D63C06B0083; Tue, 13 Oct 2020 19:48:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D14226B0085; Tue, 13 Oct 2020 19:48:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C02FA6B0087; Tue, 13 Oct 2020 19:48:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 90B6C6B0083 for ; Tue, 13 Oct 2020 19:48:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 29D56181AEF00 for ; Tue, 13 Oct 2020 23:48:33 +0000 (UTC) X-FDA: 77368544106.12.star42_3100b1427207 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 0891B1800A698 for ; Tue, 13 Oct 2020 23:48:33 +0000 (UTC) X-HE-Tag: star42_3100b1427207 X-Filterd-Recvd-Size: 2473 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 23:48:32 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D37F21D81; Tue, 13 Oct 2020 23:48:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602632912; bh=eUe1ibpAGXyJNEK+fDBIOrv/m4LYVYXKzFatuD7o1og=; h=Date:From:To:Subject:In-Reply-To:From; b=GiTkMcU+GRGDSO1jIdM5GcqFYY9rr7HvkMcZPPqiX5kKrIx/e4Bzwk4txjzqbIOb9 lE0FoKsHSFE8vb2QxuEyJ7rwKTlNIpjn4jn5S4JgG+r4hFPw5FrmDgHaxFVE0kyD2W 0t/9Y40T1ukMjaMIO7TQZopBxnO8qTKvIlz0VD6M= Date: Tue, 13 Oct 2020 16:48:30 -0700 From: Andrew Morton To: akpm@linux-foundation.org, linux-mm@kvack.org, luojiaxing@huawei.com, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 018/181] fs_parse: mark fs_param_bad_value() as static Message-ID: <20201013234830.83aisj1GJ%akpm@linux-foundation.org> In-Reply-To: <20201013164658.3bfd96cc224d8923e66a9f4e@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Luo Jiaxing Subject: fs_parse: mark fs_param_bad_value() as static We found the following warning when build kernel with W=1: fs/fs_parser.c:192:5: warning: no previous prototype for `fs_param_bad_value' [-Wmissing-prototypes] int fs_param_bad_value(struct p_log *log, struct fs_parameter *param) ^ CC drivers/usb/gadget/udc/snps_udc_core.o And no header file define a prototype for this function, so we should mark it as static. Link: https://lkml.kernel.org/r/1601293463-25763-1-git-send-email-luojiaxing@huawei.com Signed-off-by: Luo Jiaxing Signed-off-by: Andrew Morton --- fs/fs_parser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/fs_parser.c~fs_parse-mark-fs_param_bad_value-as-static +++ a/fs/fs_parser.c @@ -189,7 +189,7 @@ out: } EXPORT_SYMBOL(fs_lookup_param); -int fs_param_bad_value(struct p_log *log, struct fs_parameter *param) +static int fs_param_bad_value(struct p_log *log, struct fs_parameter *param) { return inval_plog(log, "Bad value for '%s'", param->key); } _