From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 780E7C43457 for ; Tue, 13 Oct 2020 23:48:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2890621582 for ; Tue, 13 Oct 2020 23:48:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JFA016Z7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2890621582 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C54F06B0075; Tue, 13 Oct 2020 19:48:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C05B96B0078; Tue, 13 Oct 2020 19:48:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1C8B900002; Tue, 13 Oct 2020 19:48:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0130.hostedemail.com [216.40.44.130]) by kanga.kvack.org (Postfix) with ESMTP id 84CDC6B0075 for ; Tue, 13 Oct 2020 19:48:04 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 27DA5181AEF00 for ; Tue, 13 Oct 2020 23:48:04 +0000 (UTC) X-FDA: 77368542888.16.group74_1f0e5f427207 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 08110101F4753 for ; Tue, 13 Oct 2020 23:48:04 +0000 (UTC) X-HE-Tag: group74_1f0e5f427207 X-Filterd-Recvd-Size: 3498 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 23:48:03 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5DC3C21D7A; Tue, 13 Oct 2020 23:48:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602632882; bh=1IE0rXmrIv5WEpxIUQFbF+jl/alNJTZrKr0kJ0mM3ao=; h=Date:From:To:Subject:In-Reply-To:From; b=JFA016Z7tWF4TmfyvM8J/O17jgETStu9tYsT9jjGrXOLlS2dTcRoFV0SfAmJCON88 KDBAQnw7FXtZsminykfsM2OgPZuSdnvfRoE00o+EJAPChDJBIET6YHvJFiIvbJkvOP f92uN25V4oNdQ1TpiuOmowUyVHR1Olnxiv7JCawk= Date: Tue, 13 Oct 2020 16:48:01 -0700 From: Andrew Morton To: akpm@linux-foundation.org, gregkh@linuxfoundation.org, jeyu@kernel.org, keescook@chromium.org, linux-mm@kvack.org, lkp@intel.com, maennich@google.com, mm-commits@vger.kernel.org, natechancellor@gmail.com, ndesaulniers@google.com, torvalds@linux-foundation.org, will@kernel.org, yamada.masahiro@socionext.com Subject: [patch 009/181] export.h: fix section name for CONFIG_TRIM_UNUSED_KSYMS for Clang Message-ID: <20201013234801.zMU594pMt%akpm@linux-foundation.org> In-Reply-To: <20201013164658.3bfd96cc224d8923e66a9f4e@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Nick Desaulniers Subject: export.h: fix section name for CONFIG_TRIM_UNUSED_KSYMS for Clang When enabling CONFIG_TRIM_UNUSED_KSYMS, the linker will warn about the orphan sections: (".discard.ksym") is being placed in '".discard.ksym"' repeatedly when linking vmlinux. This is because the stringification operator, `#`, in the preprocessor escapes strings. GCC and Clang differ in how they treat section names that contain \". The portable solution is to not use a string literal with the preprocessor stringification operator. Link: https://bugs.llvm.org/show_bug.cgi?id=42950 Link: https://github.com/ClangBuiltLinux/linux/issues/1166 Link: https://lkml.kernel.org/r/20200929190701.398762-1-ndesaulniers@google.com Fixes: commit bbda5ec671d3 ("kbuild: simplify dependency generation for CONFIG_TRIM_UNUSED_KSYMS") Signed-off-by: Nick Desaulniers Reported-by: kbuild test robot Suggested-by: Kees Cook Reviewed-by: Kees Cook Cc: Nathan Chancellor Cc: Masahiro Yamada Cc: Matthias Maennich Cc: Jessica Yu Cc: Greg Kroah-Hartman Cc: Will Deacon Signed-off-by: Andrew Morton --- include/linux/export.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/export.h~exporth-fix-section-name-for-config_trim_unused_ksyms-for-clang +++ a/include/linux/export.h @@ -130,7 +130,7 @@ struct kernel_symbol { * discarded in the final link stage. */ #define __ksym_marker(sym) \ - static int __ksym_marker_##sym[0] __section(".discard.ksym") __used + static int __ksym_marker_##sym[0] __section(.discard.ksym) __used #define __EXPORT_SYMBOL(sym, sec, ns) \ __ksym_marker(sym); \ _