From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07222C433DF for ; Tue, 13 Oct 2020 23:47:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A3F8121D7F for ; Tue, 13 Oct 2020 23:47:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TY6dUY5+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3F8121D7F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 48D416B0073; Tue, 13 Oct 2020 19:47:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43E4E6B0074; Tue, 13 Oct 2020 19:47:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32DAE6B0075; Tue, 13 Oct 2020 19:47:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id F14456B0073 for ; Tue, 13 Oct 2020 19:47:57 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 84FB53625 for ; Tue, 13 Oct 2020 23:47:57 +0000 (UTC) X-FDA: 77368542594.22.yard26_1904c4e27207 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 6469818038E6B for ; Tue, 13 Oct 2020 23:47:57 +0000 (UTC) X-HE-Tag: yard26_1904c4e27207 X-Filterd-Recvd-Size: 3359 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 23:47:56 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9723521D7B; Tue, 13 Oct 2020 23:47:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602632876; bh=E02l5tEJHAICIFBZCSW2oqj+4F/y71f99ImXn80EBWY=; h=Date:From:To:Subject:In-Reply-To:From; b=TY6dUY5+Ug2oirODh0yYV1mW7iYO3ifQDKr/5bFiW9Rz9QE9t9ch8jsVK3n86TZpN nabXjz6u/VGEnJUhnKV0rppG+fYx9TYDkqtTLlOBjy9II/m4gRJCRylxKmI3r7fX+h wHD+tnin5QUdepOCAy18Ct7VIUhq9h3eJBjzPDh4= Date: Tue, 13 Oct 2020 16:47:55 -0700 From: Andrew Morton To: akpm@linux-foundation.org, andreyknvl@google.com, ast@kernel.org, daniel@iogearbox.net, elver@google.com, keescook@chromium.org, linux-mm@kvack.org, masahiroy@kernel.org, maskray@google.com, miguel.ojeda.sandonis@gmail.com, mm-commits@vger.kernel.org, natechancellor@gmail.com, ndesaulniers@google.com, sedat.dilek@gmail.com, torvalds@linux-foundation.org, vincenzo.frascino@arm.com, will@kernel.org Subject: [patch 007/181] compiler-gcc: improve version error Message-ID: <20201013234755.E37ffaRXs%akpm@linux-foundation.org> In-Reply-To: <20201013164658.3bfd96cc224d8923e66a9f4e@linux-foundation.org> User-Agent: s-nail v14.8.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Nick Desaulniers Subject: compiler-gcc: improve version error As Kees suggests, doing so provides developers with two useful pieces of information: - The kernel build was attempting to use GCC. (Maybe they accidentally poked the wrong configs in a CI.) - They need 4.9 or better. ("Upgrade to what version?" doesn't need to be dug out of documentation, headers, etc.) Link: https://lkml.kernel.org/r/20200902225911.209899-8-ndesaulniers@google.com Signed-off-by: Nick Desaulniers Reviewed-by: Kees Cook Reviewed-by: Miguel Ojeda Reviewed-by: Nathan Chancellor Reviewed-by: Sedat Dilek Suggested-by: Kees Cook Tested-by: Sedat Dilek Cc: Andrey Konovalov Cc: Fangrui Song Cc: Marco Elver Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Masahiro Yamada Cc: Vincenzo Frascino Cc: Will Deacon Signed-off-by: Andrew Morton --- include/linux/compiler-gcc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/compiler-gcc.h~compiler-gcc-improve-version-error +++ a/include/linux/compiler-gcc.h @@ -12,7 +12,7 @@ /* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */ #if GCC_VERSION < 40900 -# error Sorry, your compiler is too old - please upgrade it. +# error Sorry, your version of GCC is too old - please use 4.9 or newer. #endif /* Optimization barrier */ _