From: Oscar Salvador <osalvador@suse.de>
To: n-horiguchi@ah.jp.nec.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Oscar Salvador <osalvador@suse.de>
Subject: [PATCH v5 4/4] mm,hwpoison: drop unneeded pcplist draining
Date: Tue, 13 Oct 2020 16:44:47 +0200 [thread overview]
Message-ID: <20201013144447.6706-5-osalvador@suse.de> (raw)
In-Reply-To: <20201013144447.6706-1-osalvador@suse.de>
memory_failure and soft_offline_path paths now drain pcplists by calling
get_hwpoison_page.
memory_failure flags the page as HWPoison before, so that page cannot
longer go into a pcplist, and soft_offline_page only flags a page as
HWPoison if 1) we took the page off a buddy freelist 2) the page was
in-use and we migrated it 3) was a clean pagecache.
Because of that, a page cannot longer be poisoned and be in a pcplist.
Signed-off-by: Oscar Salvador <osalvador@suse.de>
---
mm/madvise.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/mm/madvise.c b/mm/madvise.c
index 416a56b8e757..c6b5524add58 100644
--- a/mm/madvise.c
+++ b/mm/madvise.c
@@ -877,7 +877,6 @@ static long madvise_remove(struct vm_area_struct *vma,
static int madvise_inject_error(int behavior,
unsigned long start, unsigned long end)
{
- struct zone *zone;
unsigned long size;
if (!capable(CAP_SYS_ADMIN))
@@ -922,10 +921,6 @@ static int madvise_inject_error(int behavior,
return ret;
}
- /* Ensure that all poisoned pages are removed from per-cpu lists */
- for_each_populated_zone(zone)
- drain_all_pages(zone);
-
return 0;
}
#endif
--
2.26.2
next prev parent reply other threads:[~2020-10-13 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:44 [PATCH v5 0/4] HWpoison: further fixes and cleanups Oscar Salvador
2020-10-13 14:44 ` [PATCH v5 1/4] mm,hwpoison: drain pcplists before bailing out for non-buddy zero-refcount page Oscar Salvador
2020-11-25 16:26 ` Vlastimil Babka
2020-10-13 14:44 ` [PATCH v5 2/4] mm,hwpoison: take free pages off the buddy freelists Oscar Salvador
2020-11-25 16:35 ` Vlastimil Babka
2020-10-13 14:44 ` [PATCH v5 3/4] mm,hwpoison: take free pages off the buddy freelists for hugetlb Oscar Salvador
2020-10-14 0:05 ` HORIGUCHI NAOYA(堀口 直也)
2020-11-25 16:36 ` Vlastimil Babka
2020-10-13 14:44 ` Oscar Salvador [this message]
2020-10-14 0:06 ` [PATCH v5 4/4] mm,hwpoison: drop unneeded pcplist draining HORIGUCHI NAOYA(堀口 直也)
2020-11-25 16:38 ` Vlastimil Babka
2020-11-10 6:21 ` [PATCH v5 0/4] HWpoison: further fixes and cleanups Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201013144447.6706-5-osalvador@suse.de \
--to=osalvador@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox