From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B492CC433DF for ; Tue, 13 Oct 2020 09:23:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 261AF208D5 for ; Tue, 13 Oct 2020 09:23:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 261AF208D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 94A08900003; Tue, 13 Oct 2020 05:23:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FA1F900002; Tue, 13 Oct 2020 05:23:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C11A900003; Tue, 13 Oct 2020 05:23:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 50018900002 for ; Tue, 13 Oct 2020 05:23:47 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D8F01DB49 for ; Tue, 13 Oct 2020 09:23:46 +0000 (UTC) X-FDA: 77366364852.26.sack04_11050d127202 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id B5A711804B661 for ; Tue, 13 Oct 2020 09:23:46 +0000 (UTC) X-HE-Tag: sack04_11050d127202 X-Filterd-Recvd-Size: 2005 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 13 Oct 2020 09:23:46 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: rcn) with ESMTPSA id E6EE41F44FAE Date: Tue, 13 Oct 2020 11:23:39 +0200 From: Ricardo =?utf-8?Q?Ca=C3=B1uelo?= To: Michal Hocko Cc: akpm@linux-foundation.org, kernel@collabora.com, hch@lst.de, guro@fb.com, rientjes@google.com, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, linux-mm@kvack.org, sergey.senozhatsky@gmail.com, pmladek@suse.com, rostedt@goodmis.org Subject: Re: [PATCH] mm, oom: enable rate-limiting controls for oom dumps Message-ID: <20201013092339.225lb62rs7jwfzd6@rcn-XPS-13-9360> References: <20201009093014.9412-1-ricardo.canuelo@collabora.com> <20201012151804.GG29725@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201012151804.GG29725@dhcp22.suse.cz> User-Agent: NeoMutt/20171215 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Michal, Thanks for reviewing the patch and for your suggestions: On lun 12-10-2020 17:18:04, Michal Hocko wrote: > How does controling burst and interval solve the problem? Btw. this > should be a part of the changelog which should explain not only what but > also why the change is needed. > > It is true that the oom report can generate a lot of output. This is > something that is brought up for quite some time. The largest part of > the output tends to be the list of tasks and this seems to be the case > for you as well. Is the list of tasks so important that you need to have > it in the log? If not you can simply disable this part of the log > altogether by /proc/sys/vm/oom_dump_tasks. That could be another way to mitigate the problem, although losing some information. I'll try to come up with a better alternative. Cheers, Ricardo