From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5390AC433E7 for ; Mon, 12 Oct 2020 14:00:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D6D832087E for ; Mon, 12 Oct 2020 14:00:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="Sbr/oBRE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6D832087E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D954900002; Mon, 12 Oct 2020 10:00:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68831940009; Mon, 12 Oct 2020 10:00:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59ED1900003; Mon, 12 Oct 2020 10:00:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 30A73900002 for ; Mon, 12 Oct 2020 10:00:32 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B104F1EE6 for ; Mon, 12 Oct 2020 14:00:31 +0000 (UTC) X-FDA: 77363433462.03.hill09_5f07458271fb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 2C1836A5C for ; Mon, 12 Oct 2020 14:00:28 +0000 (UTC) X-HE-Tag: hill09_5f07458271fb X-Filterd-Recvd-Size: 3581 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Mon, 12 Oct 2020 14:00:27 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id s7so17742500qkh.11 for ; Mon, 12 Oct 2020 07:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Osshed0yZw01kGf9tsxsPTMgiFVwAv+3bFml5Qp/S6I=; b=Sbr/oBREuW7qcPtzuexM9iqgk70TQmYyzQXuD1cbd5tg3SM9lOdsUrYHoMeDV8DQOy UueavBzl67FQvEbouK6Moe2nIYbhuX9Hn/9BejDvPgFbCGiyk2hgSOMhEkN1TeJv/qtG QzswFmgdtJF5bzku8cKITDYpnUD0wwK34cI58duEv3gteiqgDliboq3LM6ANyw7Hw7N8 mr2mtvc7dMULRnVyov6TZVXr7YambYnUtko20U4NfXMHS8v6ODN77S0030C9VFTxb3Jg SLdFjX8tM2pYjiRg+V0DWXvSupRdsxN3aGXSBj1Av+um8cbeKqZGirKH6agH6pmHvcXi rANQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Osshed0yZw01kGf9tsxsPTMgiFVwAv+3bFml5Qp/S6I=; b=WUeLXLXJzZSbdgQylQWMbVsT2We7xLMoppm4Mp1pkfF9FSH2uKpQ+Omi9PrJdpZ+HE B3c0enDs8/Jte8YualjYDKX508mQFMHf+remUOyUy8sepf50j7hGpE/SQ3tS4D/sfc5D UYR44K2A416TzDsfjS2ljgcWQ8TLx8nLhQviLtzY6ZtbXserD5czfcstv+/f8xApVRri hlYTqy5GEdBtDSqfoPCYcnwlNzOWpjM1hMT2WMRlygqDtgZnUsR+eLpivvM0IyicrDVN fJJhOA9TE9mdjTlKsxd99+erPQcB6rv1C1NLLEkyyc2sFKBT5ex1KEKF4e+t506QtkE5 uCvA== X-Gm-Message-State: AOAM530b2Wn0WHLPMJqCZBknLl7qihxKmGZf8Ik+mFoxrfNEs8R2w+T9 7p+tr8SFenYnIZu9uSNWlSQ6fQ== X-Google-Smtp-Source: ABdhPJw5dqvVw9Iz6JJkiQZWH9PQtR8t5RXx3zTYAy1x6STroRwe5T2OtbAH+2M8GDptKbhATZiqWA== X-Received: by 2002:a05:620a:c92:: with SMTP id q18mr9436584qki.295.1602511226559; Mon, 12 Oct 2020 07:00:26 -0700 (PDT) Received: from localhost (pool-96-232-200-60.nycmny.fios.verizon.net. [96.232.200.60]) by smtp.gmail.com with ESMTPSA id t65sm12299450qkc.52.2020.10.12.07.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 07:00:25 -0700 (PDT) Date: Mon, 12 Oct 2020 09:58:52 -0400 From: Johannes Weiner To: Miaohe Lin Cc: akpm@linux-foundation.org, mhocko@kernel.org, vdavydov.dev@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: memcontrol: eliminate redundant check in __mem_cgroup_insert_exceeded() Message-ID: <20201012135852.GB188876@cmpxchg.org> References: <20201012131607.10656-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201012131607.10656-1-linmiaohe@huawei.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 12, 2020 at 09:16:07AM -0400, Miaohe Lin wrote: > The mz->usage_in_excess >= mz_node->usage_in_excess check is exactly the > else case of mz->usage_in_excess < mz_node->usage_in_excess. So we could > replace else if (mz->usage_in_excess >= mz_node->usage_in_excess) with else > equally. Also drop the comment which doesn't really explain much. > > Acked-by: Michal Hocko > Signed-off-by: Miaohe Lin Looks good to me. Acked-by: Johannes Weiner