From: Johannes Weiner <hannes@cmpxchg.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
mhocko@kernel.org, vdavydov.dev@gmail.com,
akpm@linux-foundation.org, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, shakeelb@google.com, guro@fb.com,
iamjoonsoo.kim@lge.com, laoar.shao@gmail.com,
chris@chrisdown.name, daniel@iogearbox.net, kafai@fb.com,
ast@kernel.org, jakub@cloudflare.com, linmiaohe@huawei.com,
keescook@chromium.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: memcontrol: localize mem_cgroup_sockets_enabled() check
Date: Mon, 12 Oct 2020 09:58:23 -0400 [thread overview]
Message-ID: <20201012135823.GA188876@cmpxchg.org> (raw)
In-Reply-To: <20201010104521.67262-1-songmuchun@bytedance.com>
On Sat, Oct 10, 2020 at 06:45:21PM +0800, Muchun Song wrote:
> Move the mem_cgroup_sockets_enabled() checks into memcg socket charge
> or uncharge functions, so the users don't have to explicitly check that
> condition.
>
> This is purely code cleanup patch without any functional change. But
> move the sk_memcg member of the sock structure to the CONFIG_MEMCG
> scope.
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> include/linux/memcontrol.h | 78 ++++++++++++++++++++++++++-------
> include/net/sock.h | 5 ++-
> include/net/tcp.h | 3 +-
> mm/memcontrol.c | 43 +++++++++++++-----
> net/core/sock.c | 15 +++----
> net/ipv4/inet_connection_sock.c | 6 +--
> net/ipv4/tcp_output.c | 3 +-
> 7 files changed, 111 insertions(+), 42 deletions(-)
Hm, this is almost 3 times as much code.
The sk_memcg saving on !CONFIG_MEMCG is somewhat nice, but it's not
clear how many users would benefit here. And it adds ifdefs in code.
Also memcg code now has to know about struct sock.
I'm not quite sure that this is an overall improvement.
next prev parent reply other threads:[~2020-10-12 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 10:45 Muchun Song
2020-10-12 13:58 ` Johannes Weiner [this message]
2020-10-12 16:04 ` [External] " Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201012135823.GA188876@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guro@fb.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jakub@cloudflare.com \
--cc=kafai@fb.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=laoar.shao@gmail.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=vdavydov.dev@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox