From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF3C4C433E7 for ; Fri, 9 Oct 2020 22:25:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 56FAF2231B for ; Fri, 9 Oct 2020 22:25:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="JLw9cOIA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56FAF2231B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A70B8940013; Fri, 9 Oct 2020 18:25:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A472F94000C; Fri, 9 Oct 2020 18:25:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E96E940013; Fri, 9 Oct 2020 18:25:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 6061094000C for ; Fri, 9 Oct 2020 18:25:12 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 04ED21EE6 for ; Fri, 9 Oct 2020 22:25:12 +0000 (UTC) X-FDA: 77353818864.04.cars18_2a05ee0271e4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id DD970800CD14 for ; Fri, 9 Oct 2020 22:25:11 +0000 (UTC) X-HE-Tag: cars18_2a05ee0271e4 X-Filterd-Recvd-Size: 4244 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Fri, 9 Oct 2020 22:25:11 +0000 (UTC) Received: by mail-qv1-f65.google.com with SMTP id s17so5524468qvr.11 for ; Fri, 09 Oct 2020 15:25:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=8oWWXTJLgz6k0eoay/wZw+xNoGlz9otu+1gTZ3QYQTU=; b=JLw9cOIADbCSt30KyPOolp7D8T1ydtcphV5lvGpBdT0H+g77HDzGqjI0IhTwDtshej z8W9/A5rl7Fs73WAAOZCMBnYeiPIeODDdOK72bckk1yyjqKzGzJGpGNwVGUB0vRNaqG6 ap064g18fjDLNTiIERClhqsAS5BC7X7bh6LtPx49QkjIsF0B7Xd4H4eYYxg/AdJF3NbQ 6Q2Uw/NINPLSaXbo4JkZOxArbxVx5MKT8yoo5U7zqDz0bBWlEov3++WNlmduRS66dQKB STAnvBVe/E+zYOop/N5UjYdXTGAqyB9F1cQa/HvHMUIVc87d8UVxGlSEk0HwjL0aOg35 Angg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=8oWWXTJLgz6k0eoay/wZw+xNoGlz9otu+1gTZ3QYQTU=; b=Nop9JQs2thkoj35KwmhWGIPLUUDFwaqBO2JNzwbpLUehoyARC1P5dRhj+0maKOB4sp 7LALYvwbbIf+vf/pESWyE9rbPwkitYfuSebOUvFtVCjURMG9eThlYzkO49pd17o+ETt5 Vcgf845mJDIX5ttZEz5SCsG3Rie4OoVhyXsVRn7cLWS3SeZtRp35Gl6ib9qqbKu5WRND 1UFoj2DPtkJmHNhHOJ9+PVcaPCKOAU6a5zLRbmgGoHCkrXKlrb5HW7KbhcfBBwKhGnem Db6UBTF/Thr908lrsqDpqxllZHmabbe6Nsmt/E5w1sj3ZbvuWVXJZI7tHIahNLWd8hr4 w+8A== X-Gm-Message-State: AOAM530VgNZTLRpmYZuQE4D1O3W9vN6+hzkgQOmNBA2NG2yX3jspxxdn eB3CROGOZcZ5GvEvDxGqy87X4A== X-Google-Smtp-Source: ABdhPJx4KrjLeEug0hrbNvxkGQnKMdvwXI9Ssl/PdIck48j/G9dQSZkfDxN9OyPFgyOzHX6NhQzoFg== X-Received: by 2002:a0c:9a01:: with SMTP id p1mr14524630qvd.61.1602282310859; Fri, 09 Oct 2020 15:25:10 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id t3sm7141813qtq.24.2020.10.09.15.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 15:25:10 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kR0p3-002qLD-KY; Fri, 09 Oct 2020 19:25:09 -0300 Date: Fri, 9 Oct 2020 19:25:09 -0300 From: Jason Gunthorpe To: Andrew Morton Cc: Christian =?utf-8?B?S8O2bmln?= , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, chris@chris-wilson.co.uk, airlied@redhat.com, daniel@ffwll.ch, sumit.semwal@linaro.org, willy@infradead.org, jhubbard@nvidia.com, Miaohe Lin Subject: Re: [PATCH 1/6] mm: mmap: fix fput in error path Message-ID: <20201009222509.GC5177@ziepe.ca> References: <20201009150342.1979-1-christian.koenig@amd.com> <20201009150420.450833e3830b9d39a2385dd9@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201009150420.450833e3830b9d39a2385dd9@linux-foundation.org> Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 09, 2020 at 03:04:20PM -0700, Andrew Morton wrote: > On Fri, 9 Oct 2020 17:03:37 +0200 "Christian K=C3=B6nig" wrote: >=20 > > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." > > adds a workaround for a bug in mmap_region. > >=20 > > As the comment states ->mmap() callback can change > > vma->vm_file and so we might call fput() on the wrong file. > >=20 > > Revert the workaround and proper fix this in mmap_region. > >=20 >=20 > Doesn't this patch series address the same thing as > https://lkml.kernel.org/r/20200916090733.31427-1-linmiaohe@huawei.com? Same basic issue, looks like both of these patches should be combined to plug it fully. Jason=20