From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D933DC43457 for ; Fri, 9 Oct 2020 22:04:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4D7AB22258 for ; Fri, 9 Oct 2020 22:04:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Sqt8Kxsm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4D7AB22258 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ACF7094000D; Fri, 9 Oct 2020 18:04:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A807D94000C; Fri, 9 Oct 2020 18:04:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 995D094000D; Fri, 9 Oct 2020 18:04:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 6E75994000C for ; Fri, 9 Oct 2020 18:04:23 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0A99E181AE868 for ; Fri, 9 Oct 2020 22:04:23 +0000 (UTC) X-FDA: 77353766406.29.steam14_0c13b43271e4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id DF8A7180868C0 for ; Fri, 9 Oct 2020 22:04:22 +0000 (UTC) X-HE-Tag: steam14_0c13b43271e4 X-Filterd-Recvd-Size: 2335 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 9 Oct 2020 22:04:22 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 21CE12225B; Fri, 9 Oct 2020 22:04:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602281061; bh=oITbHTmVfb1q7fGqfRr1elEf4VBd3T6psegkhAry820=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sqt8KxsmiMnGuR0FT3Y4aouz0n876VypJIivZK9FUCA4pSf8ob4uuB47fWSLQVpHe jX2gkLdcbNdzObqUeuxaPZ9R6zqIm9NdO9kF4Eo6wFiR916yXnFU9ACe7jRwX0wz2u mpcdILw6zl4jSuUJsqNpaZKW94F3xjT8wN+ua4cY= Date: Fri, 9 Oct 2020 15:04:20 -0700 From: Andrew Morton To: =?ISO-8859-1?Q?"Christian_K=F6nig"?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, chris@chris-wilson.co.uk, airlied@redhat.com, daniel@ffwll.ch, sumit.semwal@linaro.org, willy@infradead.org, jhubbard@nvidia.com, jgg@ziepe.ca, Miaohe Lin Subject: Re: [PATCH 1/6] mm: mmap: fix fput in error path Message-Id: <20201009150420.450833e3830b9d39a2385dd9@linux-foundation.org> In-Reply-To: <20201009150342.1979-1-christian.koenig@amd.com> References: <20201009150342.1979-1-christian.koenig@amd.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 9 Oct 2020 17:03:37 +0200 "Christian K=F6nig" wrote: > Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." > adds a workaround for a bug in mmap_region. >=20 > As the comment states ->mmap() callback can change > vma->vm_file and so we might call fput() on the wrong file. >=20 > Revert the workaround and proper fix this in mmap_region. >=20 Doesn't this patch series address the same thing as https://lkml.kernel.org/r/20200916090733.31427-1-linmiaohe@huawei.com?