From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7C66C04EBE for ; Thu, 8 Oct 2020 14:14:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 27EAB21897 for ; Thu, 8 Oct 2020 14:14:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="fUX+sAvA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27EAB21897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 61E066B0062; Thu, 8 Oct 2020 10:14:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CF2D900002; Thu, 8 Oct 2020 10:14:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BC246B006C; Thu, 8 Oct 2020 10:14:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 1BE666B0062 for ; Thu, 8 Oct 2020 10:14:25 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A6EA31EE6 for ; Thu, 8 Oct 2020 14:14:24 +0000 (UTC) X-FDA: 77348953248.24.edge01_3b0bb71271d8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 84E781A4A5 for ; Thu, 8 Oct 2020 14:14:24 +0000 (UTC) X-HE-Tag: edge01_3b0bb71271d8 X-Filterd-Recvd-Size: 6335 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Thu, 8 Oct 2020 14:14:23 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id q5so6686109wmq.0 for ; Thu, 08 Oct 2020 07:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=SKpxYdUurmpOS5BkncePHyl2hsG1ycnDl5RK5GsXoXc=; b=fUX+sAvAlhLn8s9pMBv+CAJuKweXXzPXeQaXLLKXLzS93kfhlCTgAvIlGdaRzQ60Ej 9iQX+6UZwIrYj21RORZgWLqnIxjjHHTZso4kF+xYv3yiS3nKviqo+RBzttefQD3uGI0n ypnYadZqRu/XN5JvDkbxL51lo817XHh2ps7SE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=SKpxYdUurmpOS5BkncePHyl2hsG1ycnDl5RK5GsXoXc=; b=DyrRx5Z3AnSer6xhMYAsv7S0SmIhx/gFtcj8aJCW2fc8Du/aTNBQTv+vKcS6aCl1aF bZhs1FodzVgKVbr3+H8xVl0UaLr79fwY5fjuNtFl8lWlmmA7t0R7TtTD5Gsg6CyyW6cE mD3hD/Jga4BsOeAWzia3noYHOMtECFolEOw3rK7p/8VEpJ59K35J9r3chBdYDaXA/igZ 7txy85KWGHY86IRjJQ2Uk6KCW4CVpW2riqYkjmeZJ1IkYzbTEO7IONIho2iS34uLvOzL UDMYaZxAsDSOG924CbXLIYouSgvKHszK9fT4vsN7h3dGRP+R0SZRO+cS0uqxOfiP/B6A Hamg== X-Gm-Message-State: AOAM531c873NTUS+tCOnRLtxLhG2f/puJiRobycvHYXHLrxJ5b/ZMsjB UU3tYnC9Ddj0qk6Xam7UZnJpxA== X-Google-Smtp-Source: ABdhPJyZe4Z21U8phi7d2Xe/UNgxW53htdWoW10px59ECyLFlG/URS67GHq0loHUzd4W89hC8MwYlg== X-Received: by 2002:a1c:bd43:: with SMTP id n64mr8613712wmf.113.1602166462550; Thu, 08 Oct 2020 07:14:22 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id x81sm7251502wmb.11.2020.10.08.07.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 07:14:21 -0700 (PDT) Date: Thu, 8 Oct 2020 16:14:19 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, chris@chris-wilson.co.uk, airlied@redhat.com, akpm@linux-foundation.org, sumit.semwal@linaro.org Subject: Re: [PATCH 2/4] drm/prime: document that use the page array is deprecated Message-ID: <20201008141419.GH438822@phenom.ffwll.local> Mail-Followup-To: Christian =?iso-8859-1?Q?K=F6nig?= , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, chris@chris-wilson.co.uk, airlied@redhat.com, akpm@linux-foundation.org, sumit.semwal@linaro.org References: <20201008112342.9394-1-christian.koenig@amd.com> <20201008112342.9394-2-christian.koenig@amd.com> <20201008140914.GF438822@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20201008140914.GF438822@phenom.ffwll.local> X-Operating-System: Linux phenom 5.7.0-1-amd64 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 08, 2020 at 04:09:14PM +0200, Daniel Vetter wrote: > On Thu, Oct 08, 2020 at 01:23:40PM +0200, Christian K=F6nig wrote: > > We have reoccurring requests on this so better document that > > this approach doesn't work and dma_buf_mmap() needs to be used instea= d. > >=20 > > Signed-off-by: Christian K=F6nig > > --- > > drivers/gpu/drm/drm_prime.c | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > >=20 > > diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.= c > > index 4910c446db83..16fa2bfc271e 100644 > > --- a/drivers/gpu/drm/drm_prime.c > > +++ b/drivers/gpu/drm/drm_prime.c > > @@ -956,7 +956,7 @@ EXPORT_SYMBOL(drm_gem_prime_import); > > /** > > * drm_prime_sg_to_page_addr_arrays - convert an sg table into a pag= e array > > * @sgt: scatter-gather table to convert > > - * @pages: optional array of page pointers to store the page array i= n > > + * @pages: deprecated array of page pointers to store the page array= in > > * @addrs: optional array to store the dma bus address of each page > > * @max_entries: size of both the passed-in arrays > > * > > @@ -965,6 +965,11 @@ EXPORT_SYMBOL(drm_gem_prime_import); > > * > > * Drivers can use this in their &drm_driver.gem_prime_import_sg_tab= le > > * implementation. > > + * > > + * Specifying the pages array is deprecated and strongly discouraged= for new > > + * drivers. The pages array is only useful for page faults and those= can > > + * corrupt fields in the struct page if they are not handled by the = exporting > > + * driver. > > */ >=20 > I'd make this a _lot_ stronger: Aside from amdgpu and radeon all driver= s > using this only need it for the pages array. Imo just open-code the sg > table walking loop in amdgpu/radeon (it's really not much code), and th= en > drop the dma_addr_t parameter from this function here (it's set to NULL= by > everyone else). >=20 > And then deprecate this entire function here with a big warning that a) > dma_buf_map_attachment is allowed to leave the struct page pointers NUL= L > and b) this breaks mmap, users must call dma_buf_mmap instead. >=20 > Also maybe make it an uppercase DEPRECATED or something like that :-) OK I just realized I missed nouveau. That would be 3 places where we need to stuff the dma_addr_t list into something ttm can take. Still feels better than this half-deprecated function kludge ... -Daniel > -Daniel >=20 > > int drm_prime_sg_to_page_addr_arrays(struct sg_table *sgt, struct pa= ge **pages, > > dma_addr_t *addrs, int max_entries) > > --=20 > > 2.17.1 > >=20 >=20 > --=20 > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch