From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F3BEC41604 for ; Tue, 6 Oct 2020 20:51:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7395D208C7 for ; Tue, 6 Oct 2020 20:51:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7395D208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9A0776B005C; Tue, 6 Oct 2020 16:51:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9267E6B005D; Tue, 6 Oct 2020 16:51:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EDA46B0062; Tue, 6 Oct 2020 16:51:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 53AA06B005C for ; Tue, 6 Oct 2020 16:51:14 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DE86A362B for ; Tue, 6 Oct 2020 20:51:13 +0000 (UTC) X-FDA: 77342695626.04.meat29_0714af1271c9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id BDB5D8002CCE for ; Tue, 6 Oct 2020 20:51:13 +0000 (UTC) X-HE-Tag: meat29_0714af1271c9 X-Filterd-Recvd-Size: 1963 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Tue, 6 Oct 2020 20:51:12 +0000 (UTC) IronPort-SDR: TsbQS2+qz5ail40ZaQ+OBgiwNfw9GKVLI1WgnzJAycqYwojHXXrA0db7MQc2PQ/eP/qTTOpuLR MTHt3EN6TMIA== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="144077837" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="144077837" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 13:51:08 -0700 IronPort-SDR: 6MRuPVv54ufhdqMKoRfgdP755q19MLAqZ7dy+90lhG8ZFdp0YZpjBX2Y3q62KmXwHWiwM959PQ uoWjHZKWSioA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="297299459" Received: from viggo.jf.intel.com (HELO localhost.localdomain) ([10.54.77.144]) by fmsmga008.fm.intel.com with ESMTP; 06 Oct 2020 13:51:07 -0700 Subject: [RFC][PATCH 00/12] mm: tweak page cache migration To: linux-kernel@vger.kernel.org Cc: Dave Hansen ,npiggin@gmail.com,akpm@linux-foundation.org,willy@infradead.org,yang.shi@linux.alibaba.com,linux-mm@kvack.org From: Dave Hansen Date: Tue, 06 Oct 2020 13:51:03 -0700 Message-Id: <20201006205103.268F74A9@viggo.jf.intel.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: First of all, I think this little slice of code is a bit under-documented. Perhaps this will help clarify things. I'm pretty confident the page_count() check in the first patch is right, which is why I removed it outright. The xas_load() check is a bit murkier, so I just left a warning in for it. Cc: Nicholas Piggin Cc: Andrew Morton Cc: Matthew Wilcox (Oracle) Cc: Yang Shi Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org