From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B00FC46466 for ; Mon, 5 Oct 2020 14:59:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 73B7C2076E for ; Mon, 5 Oct 2020 14:59:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="B9OJw1YX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73B7C2076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C1CFF6B0071; Mon, 5 Oct 2020 10:59:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCC7D8E0001; Mon, 5 Oct 2020 10:59:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABB8B6B0073; Mon, 5 Oct 2020 10:59:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 7BD1D6B0071 for ; Mon, 5 Oct 2020 10:59:25 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EF3493630 for ; Mon, 5 Oct 2020 14:59:24 +0000 (UTC) X-FDA: 77338180248.06.sack12_3400aaa271be Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin06.hostedemail.com (Postfix) with ESMTP id 7B3B110163EDA for ; Mon, 5 Oct 2020 14:59:24 +0000 (UTC) X-HE-Tag: sack12_3400aaa271be X-Filterd-Recvd-Size: 3570 Received: from mail-qv1-f67.google.com (mail-qv1-f67.google.com [209.85.219.67]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Mon, 5 Oct 2020 14:59:23 +0000 (UTC) Received: by mail-qv1-f67.google.com with SMTP id ev17so1816840qvb.3 for ; Mon, 05 Oct 2020 07:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RT0ma1EUakIzUMYHMs6mAe4vLDvK12cOAN+Y7MwGXfk=; b=B9OJw1YX9ajKEgG2ZKYbqsIYA1hwymQvhH6ShC9QsEQFp8VVEdYzqPKjw83OandrR/ Ziwhh45leCFbegeu2+saSiPSP4diJGDchgw14+zNrusKHY3t3NIbPxSodYM1WW13uZyL G8uYKZd6grR+pRLL2zY8mcn1aHDP+x38Lx7c+feUzm3cgw0akljm4ATYFEHz/Stsgdd+ cXVeaPQOh1UxMl9o7+ITFNfiw9rZjpuiW3TqZWdiu/2XxhVpjwur8k0KeAPDrBv7aeIp uC2FY9F0eI4/oWn1Iu7I29gFNQ9vgSV3eHxekuhX/BCr/gMM1OWyg2VgesHLKCGh0lQS mWVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RT0ma1EUakIzUMYHMs6mAe4vLDvK12cOAN+Y7MwGXfk=; b=NtJiwDTPZHz6abHlWT8uFFXhyBlllkD34stYXOxi/cbbEg4t5G++zwduC72H0MNqk8 YuEgXlkxipfd0LOCpvY8BdO/s/c3EpkB3iXGIwkZ+kI4shbQPta9CWPDm9SkXZjBVQcG E7Zs9qdaAQTUvOR/YF/ZQThEixDTNgR7TNPf6L4TSWKNg3eCAdhcJGoFlFuO9ecgtp7+ NkleOP8I4WapncvlMuQEIMTnuvjrzcsRW4fC9mF3QOFBbiO8WeF/Yej2TL7huKPV7Blw JSluarkBJ8bt8apauzdItS7keeLwepTtW3ZOSjL028867R/KgQlURBH7rkliV7D7tfV8 3vIA== X-Gm-Message-State: AOAM531URG9R7Nd3OD9j2r4JFee0riH8oc4Lm41lOKaeYp6p1XEBtvVZ DsTVvxJDlZMEMIasXAp3c/t1jQ== X-Google-Smtp-Source: ABdhPJyNbXVslMrpzIjiy8waMqYvFIS9jqQ7LFXxftd6fApSEGpz/R9+9D/RQRc1mvSJnkDm08178A== X-Received: by 2002:a0c:c407:: with SMTP id r7mr122718qvi.36.1601909963083; Mon, 05 Oct 2020 07:59:23 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:4c18]) by smtp.gmail.com with ESMTPSA id l30sm3288637qta.73.2020.10.05.07.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 07:59:21 -0700 (PDT) Date: Mon, 5 Oct 2020 10:57:49 -0400 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , Shakeel Butt , Michal Hocko , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH v5 3/4] mm: introduce page memcg flags Message-ID: <20201005145749.GA3390@cmpxchg.org> References: <20201002172559.4000748-1-guro@fb.com> <20201002172559.4000748-4-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201002172559.4000748-4-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 02, 2020 at 10:25:58AM -0700, Roman Gushchin wrote: > The lowest bit in page->memcg_data is used to distinguish between > struct memory_cgroup pointer and a pointer to a objcgs array. > All checks and modifications of this bit are open-coded. > > Let's formalize it using page memcg flags, defined in enum > page_memcg_data_flags. > > Additional flags might be added later. > > Signed-off-by: Roman Gushchin > Reviewed-by: Shakeel Butt Acked-by: Johannes Weiner