From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E31C6C4727D for ; Mon, 5 Oct 2020 12:07:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 65A1D2075A for ; Mon, 5 Oct 2020 12:07:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="JzPQYsYe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65A1D2075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D93A96B0062; Mon, 5 Oct 2020 08:07:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D45A98E0001; Mon, 5 Oct 2020 08:07:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5A6B6B006C; Mon, 5 Oct 2020 08:07:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 98D256B0062 for ; Mon, 5 Oct 2020 08:07:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 31E85181AE871 for ; Mon, 5 Oct 2020 12:07:40 +0000 (UTC) X-FDA: 77337747480.20.goat68_31100cb271bd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 0796B180C07AF for ; Mon, 5 Oct 2020 12:07:39 +0000 (UTC) X-HE-Tag: goat68_31100cb271bd X-Filterd-Recvd-Size: 3817 Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Mon, 5 Oct 2020 12:07:37 +0000 (UTC) Received: by mail-lf1-f67.google.com with SMTP id d24so6566760lfa.8 for ; Mon, 05 Oct 2020 05:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fYR1Nmn/SpWkgpyX+uei+ZKAH5DyVucsvO+KSbfsU+A=; b=JzPQYsYeztLvHWehT5mOujyQmFO+RKC98pQTTUK86iCZTx0iwmgGXMmFoC+WdHDwSI hHMTgbULsnIx2OKc/BGWAowEQBDGjHiWwcGCP9M6VrOzh+WZLQGiOfgWN8IDaL+Kow1p yJL5ygNjJ4GvVfUBSCERc7bnzQoX8/7BiyWYg82zKH63X1QZjX1Gevr1u6mJG2iqub+w ENn3DtTGrbqS13bl0YQcoMonrD2ljqPdT8WQgQ7FHhan6U6V/xiyd9jsIMBCAZnlAnJp JaEh/tzXEXoo4P/BgJOaaJmtNMV7HmU6fPH5auX2RPa4GyzsRaRxPVvb/NY2jNXpINoe EbSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fYR1Nmn/SpWkgpyX+uei+ZKAH5DyVucsvO+KSbfsU+A=; b=er+kXFmNu/lwsvAJr37c/k32ylt+9SrAB0npVPnUXhs5Cp3gBaHdjhnI4Mxrm+huHS LnBHfM/JBl0qN6tM1B5BRjvIPRrOYDFFUMyOluckZWT+vNFrjEp2FurKY/gSqHq5wteY dbSTbh6Na+Xi2EPlFa7dJKXtdErSI0WDf35g6GhVrWwy3xlCsHvg5dRcOr+iW5cf9Pky 4HmHI4aJUcG4kyJ3SWCpzSehJVWLHWWPNV8VxyRF3Md5FMlV8VIDJKkgzL3sE9KWMX32 LpZ02VQLwJiUMg+qj7xEOf2ufF8vYkT7Oz8V30mKFleiyGx80oWoDIydO6Nyk1BGCRLE Wq/g== X-Gm-Message-State: AOAM532BmVVppyNS4uGYOoOJND9367/f648T5jHNlffc2Kbt3LA3BI9/ U6D8T0jv6NvxOAhRravefqaA6163FQ3tvw== X-Google-Smtp-Source: ABdhPJzo4PTRFoa6ALXvF1Wbiv/N8HVQluFWZRMTGVTg0gR7ClpeuW2hai2T2NHeK1tm7ybpD2BlfQ== X-Received: by 2002:ac2:5a44:: with SMTP id r4mr3685000lfn.159.1601899654951; Mon, 05 Oct 2020 05:07:34 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id p18sm543265ljn.127.2020.10.05.05.07.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Oct 2020 05:07:34 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 18CD6103B11; Mon, 5 Oct 2020 15:07:35 +0300 (+03) Date: Mon, 5 Oct 2020 15:07:35 +0300 From: "Kirill A. Shutemov" To: Peter Xu Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , Andrew Morton Subject: Re: [PATCH v2] mm: Remove src/dst mm parameter in copy_page_range() Message-ID: <20201005120735.hx55z63vlmgr5jhy@box> References: <20201002192647.7161-1-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201002192647.7161-1-peterx@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 02, 2020 at 03:26:47PM -0400, Peter Xu wrote: > Both of the mm pointers are not needed after commit 7a4830c380f3 ("mm/fork: > Pass new vma pointer into copy_page_range()"). > > Jason Gunthorpe also reported that the ordering of copy_page_range() is odd. > Since working at it, reorder the parameters to be logical, by (1) always put > the dst_* fields to be before src_* fields, and (2) keep the same type of > parameters together. > > CC: Jason Gunthorpe > CC: Andrew Morton > Reported-by: Kirill A. Shutemov > Signed-off-by: Peter Xu Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov