From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61102C4363D for ; Fri, 2 Oct 2020 07:59:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D5D17206A5 for ; Fri, 2 Oct 2020 07:59:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="Zzo+yPbj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5D17206A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 223776B005D; Fri, 2 Oct 2020 03:59:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D37E6B006E; Fri, 2 Oct 2020 03:59:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C2246B0071; Fri, 2 Oct 2020 03:59:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id D3E036B005D for ; Fri, 2 Oct 2020 03:59:38 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5A7E93631 for ; Fri, 2 Oct 2020 07:59:38 +0000 (UTC) X-FDA: 77326236036.08.rings08_3a0ba1f271a2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 34ECF1819E785 for ; Fri, 2 Oct 2020 07:59:38 +0000 (UTC) X-HE-Tag: rings08_3a0ba1f271a2 X-Filterd-Recvd-Size: 3460 Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 07:59:36 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4C2j7n02Q7z9sSC; Fri, 2 Oct 2020 17:59:32 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1601625573; bh=OkRahBuUgOJ+bPRpFw5pqVSDAYrGe4TbxIqbLavU76g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Zzo+yPbjZpOtIwXGdeQwoVvDqciTsmluz+FdmnJYFEnfdA7EvMpf8gAh/U5eABLzE xERAmVmjTlP4nJrN1Bclo1hH37ZvuZgQNJx67lYfeeFl/hFPdfscdWlinNJyavvlWC WM1ibG4scqzqhP4SUoh6aKBSeUwYFlIjQ1YaluX5Dc43iEFwrSA4qDw/yXyx015DB0 pdBobNhw6kD/OhBwc+d/tLLCw/K9sHnaS2qhH6gIh38HSAJSgwvBOulV91pU6YbfN3 DxL4M8I6XdXNKJKwl05VWWaiQLVMGVhZlH8IcnF/t/90qQ/I8WpCpINoL6ePXRhTpz Zv2hn7z8ps+6Q== Date: Fri, 2 Oct 2020 17:59:31 +1000 From: Stephen Rothwell To: John Hubbard Cc: Andrew Morton , Linux Next , LKML , Subject: Re: [PATCH] selftests/vm: fix: make check_config.sh executable Message-ID: <20201002175931.5317ef64@canb.auug.org.au> In-Reply-To: <20201002064811.435769-1-jhubbard@nvidia.com> References: <20201002064811.435769-1-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/xtO5/x_LCXVCRm_BYvugP.k"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --Sig_/xtO5/x_LCXVCRm_BYvugP.k Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi John, On Thu, 1 Oct 2020 23:48:11 -0700 John Hubbard wrote: > > commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs > dependency") created the new check_config.sh file without the execute > bits set. This is a problem because the Makefile runs it with "./", so > now "make" is failing in that directory. >=20 > The posted patch [1] does seem to have it as an executable file, so I'm > not sure how this happened. But in any case, make check_config.sh > executable again, so that "make" in selftests/vm works once again. The correct fix is to make sure that the Makefile runs it explicitly with a shell because is such a patch is applied with patch(1), the execute bit will not be preserved. See e.g. in the top level Makefile: $(CONFIG_SHELL) $(srctree)/scripts/gen_autoksyms.sh $@ --=20 Cheers, Stephen Rothwell --Sig_/xtO5/x_LCXVCRm_BYvugP.k Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl923eMACgkQAVBC80lX 0Gy/vAgAkrfjf16OkbBuUzkb+lkFNt8sQhXlaysO4C7GjbSbzoyCkTJav+xGbrk2 JyQobQe7CkNKgh25sHxL1Mo2ZOoDhydqdzgt22q0iu6Df1j5fqmhK/3qROpT+Jsj i+L4gmdqNQ9uMO9hiX/FBRkCaDCTmjaC+VoBgHYFvqDD2210aOrwYWmokUWh30Mx 5LYY1Z3pfvPwJJEs9DftBGbW1IwgcP/Pqz+DNcizWWA0dJZt2xz4xBFpf9PmbLY6 GEYBrh6dFOQJTgU+GGnTcgzkhhQxnEjHfDa/ATp0m/7ij4ejwueP1ikqxkUGaYsX Zl03iFomQqEcOtoznce1ewRnfR36fQ== =1EHW -----END PGP SIGNATURE----- --Sig_/xtO5/x_LCXVCRm_BYvugP.k--