From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896B3C35257 for ; Fri, 2 Oct 2020 22:00:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC6BF20719 for ; Fri, 2 Oct 2020 22:00:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hrjjWRl7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC6BF20719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D528C6B0080; Fri, 2 Oct 2020 18:00:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1B0D6B0081; Fri, 2 Oct 2020 18:00:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70775900002; Fri, 2 Oct 2020 17:59:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 4F29C6B0080 for ; Fri, 2 Oct 2020 17:59:49 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E97038249980 for ; Fri, 2 Oct 2020 21:59:48 +0000 (UTC) X-FDA: 77328353256.18.baby88_5d16bef271a7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id BDFEC100E44F5 for ; Fri, 2 Oct 2020 21:59:48 +0000 (UTC) X-HE-Tag: baby88_5d16bef271a7 X-Filterd-Recvd-Size: 2570 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 21:59:48 +0000 (UTC) Received: from X1 (c-76-21-107-111.hsd1.ca.comcast.net [76.21.107.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC29420719; Fri, 2 Oct 2020 21:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601675987; bh=GX3SlIpSpsmf0/iZGt5G8efHVWaAJE8GOD956nTu+uM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hrjjWRl7Pc8btXlVDSBjiNYuf9lAmJ6uyjjkUzgArCfosqCfS6P2aPfBC46vYPVrt CqHeM9+i3hWZZ2yc2N+04/TJPWej7hPMA0jvCvT13jf18EE5Ja4KfTqp7pLQ2xI2Ou vyWsKDrnVOMYVUzAIYGw2PGZ9LSs+6b4rYGqO9w4= Date: Fri, 2 Oct 2020 14:59:45 -0700 From: Andrew Morton To: John Hubbard Cc: Stephen Rothwell , Linux Next , LKML , Subject: Re: [PATCH v2 2/2] selftests/vm: fix run_vmtest.sh: restore executable bits, and "s" in name Message-Id: <20201002145945.c5abb5f57dbeac30351b7757@linux-foundation.org> In-Reply-To: <20201002084049.556824-3-jhubbard@nvidia.com> References: <20201002084049.556824-1-jhubbard@nvidia.com> <20201002084049.556824-3-jhubbard@nvidia.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2 Oct 2020 01:40:49 -0700 John Hubbard wrote: > commit cb2ab76685d7 ("selftests/vm: rename run_vmtests --> > run_vmtests.sh") changed the name of run_vmtests to run_vmtest.sh, but > inadvertently dropped the executable bits. We cannot depend on the x bit. Because downloading linux-foo.patch.gz and installing it with patch(1) is a supported way of obtaining Linux. And patch(1) loses the x bit. If $(CONFIG_SHELL) is unavailable then invoking the script with "/bin/sh foo.sh" should do the trick. > Somehow the name is missing an "s", too. Fix both of these problems by > renaming, and restoring the executable bits. But that's what your patch did! tools/testing/selftests/vm/{run_vmtests => run_vmtest.sh} | 0 Here: https://lkml.kernel.org/r/20200929212747.251804-4-jhubbard@nvidia.com So all confused. I'll drop this version - please redo and resend when convenient?