From: Roman Gushchin <guro@fb.com>
To: kernel test robot <lkp@intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
<kbuild-all@lists.01.org>, LKML <linux-kernel@vger.kernel.org>,
Bastian Bittorf <bb@npl.de>, Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Shakeel Butt <shakeelb@google.com>
Subject: Re: [PATCH] mm: memcg/slab: fix slab statistics in !SMP configuration
Date: Thu, 1 Oct 2020 17:55:59 -0700 [thread overview]
Message-ID: <20201002005559.GF2706729@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <202010020814.M5nb692Y-lkp@intel.com>
On Fri, Oct 02, 2020 at 08:08:40AM +0800, kbuild test robot wrote:
> Hi Roman,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on mmotm/master]
It's a bogus error, the patch was applied onto mmotm/master, which doesn't
contain necessary slab controller patches.
Thanks!
>
> url: https://github.com/0day-ci/linux/commits/Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114
> base: git://git.cmpxchg.org/linux-mmotm.git master
> config: i386-randconfig-s002-20200930 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.2-201-g24bdaac6-dirty
> # https://github.com/0day-ci/linux/commit/3e4248734433fea1624e4971258042af2f231e02
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Roman-Gushchin/mm-memcg-slab-fix-slab-statistics-in-SMP-configuration/20201002-044114
> git checkout 3e4248734433fea1624e4971258042af2f231e02
> # save the attached .config to linux build tree
> make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from include/linux/mm.h:1317,
> from include/linux/memcontrol.h:20,
> from include/linux/swap.h:9,
> from include/linux/suspend.h:5,
> from arch/x86/kernel/asm-offsets.c:13:
> include/linux/vmstat.h: In function '__mod_node_page_state':
> >> include/linux/vmstat.h:295:6: error: implicit declaration of function 'vmstat_item_in_bytes' [-Werror=implicit-function-declaration]
> 295 | if (vmstat_item_in_bytes(item)) {
> | ^~~~~~~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [scripts/Makefile.build:99: arch/x86/kernel/asm-offsets.s] Error 1
> make[2]: Target '__build' not remade because of errors.
> make[1]: *** [Makefile:1139: prepare0] Error 2
> make[1]: Target 'prepare' not remade because of errors.
> make: *** [Makefile:179: sub-make] Error 2
> make: Target 'prepare' not remade because of errors.
>
> vim +/vmstat_item_in_bytes +295 include/linux/vmstat.h
>
> 291
> 292 static inline void __mod_node_page_state(struct pglist_data *pgdat,
> 293 enum node_stat_item item, int delta)
> 294 {
> > 295 if (vmstat_item_in_bytes(item)) {
> 296 VM_WARN_ON_ONCE(delta & (PAGE_SIZE - 1));
> 297 delta >>= PAGE_SHIFT;
> 298 }
> 299
> 300 node_page_state_add(delta, pgdat, item);
> 301 }
> 302
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.01.org_hyperkitty_list_kbuild-2Dall-40lists.01.org&d=DwIBAg&c=5VD0RTtNlTh3ycd41b3MUw&r=jJYgtDM7QT-W-Fz_d29HYQ&m=a91mqnAqjcA0iLpnhkpBXCmVqE_BuOIny-YmkB8jp2U&s=4EiiISKLS8YORtIb2rqP7oxVeqhBmKzMHqJzWhDAuMw&e=
next prev parent reply other threads:[~2020-10-02 0:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201001203931.GD2706729@carbon.DHCP.thefacebook.com>
2020-10-02 0:08 ` kernel test robot
2020-10-02 0:55 ` Roman Gushchin [this message]
2020-10-02 5:34 ` [kbuild-all] " Philip Li
2020-10-02 17:55 ` Roman Gushchin
2020-10-12 23:05 ` Philip Li
2020-10-13 0:31 ` Roman Gushchin
2020-10-02 21:43 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002005559.GF2706729@carbon.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=bb@npl.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=shakeelb@google.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox