From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAD77C47420 for ; Wed, 30 Sep 2020 13:31:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 46E5D207C3 for ; Wed, 30 Sep 2020 13:31:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="M/saRZPo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46E5D207C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 86DCF8E0001; Wed, 30 Sep 2020 09:31:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F6D46B0062; Wed, 30 Sep 2020 09:31:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BDB58E0001; Wed, 30 Sep 2020 09:31:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0094.hostedemail.com [216.40.44.94]) by kanga.kvack.org (Postfix) with ESMTP id 53CA86B005C for ; Wed, 30 Sep 2020 09:31:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 13012181AE863 for ; Wed, 30 Sep 2020 13:31:02 +0000 (UTC) X-FDA: 77319813564.12.verse50_5f0f70f27193 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 32A521801303C for ; Wed, 30 Sep 2020 13:31:01 +0000 (UTC) X-HE-Tag: verse50_5f0f70f27193 X-Filterd-Recvd-Size: 4575 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Wed, 30 Sep 2020 13:31:00 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id w11so2165952lfn.2 for ; Wed, 30 Sep 2020 06:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JfK3MmLNn/xikiHKUDkDYMDDzeu40/mWS8wJhCh6qYc=; b=M/saRZPo7pkqFqy6qBsQswXcNt1edm1zwI0b80Y4eCdlbAPOuDjTN9Xq4g66qvpLDm RPCAzNaGKRIWDJkpWF5WoSdOir88M7/gJuP/NULBNwjr2mYsuj26ELEWlnbR9G+cfgu9 oUwq2zsJnsqcG7IsUsXlaLkAaEvUv40x8XUT8g5ayBThP7S1k24zihlRTpTh2Zu7xDbT p6wzRKRU2wQpQ6+29Fai0m6iGiwFXLO8UQ4i1a9ECzn8hWNekmb/XEPQdLiT/mZT1Q4l WI8xCpvN2yn3p+9WcPaKS2k6SJ/QnrInh4aO5xlEzlWAP6+RwQVLlYuQW+CxVuiRs9yr JUsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JfK3MmLNn/xikiHKUDkDYMDDzeu40/mWS8wJhCh6qYc=; b=HhqM9X0+JueXaqWaWlTWJ7EVAqMAzbBVVhczcvspudP1CUxyFgf+eUVJ3psZ+F6Dtk w2hjJ2syAfGXjzPOeVsJu/Z742kTV91AweQl87jf/t4XOrALI/q/PBJsc4xVftK+1l5l ht03CRJgQc5MNlSxxAubm4ww1j2EJMV+lZH8OJpi4DSclr4He8QpDzcp8Oaxxm7Di+e4 0CyeLS3fXXJyk/mcnmrTQYXJhwsZrSvOSRgIoX8gr6Xv0FDiWNP4SSF8cjaDhF1paUHe nKICUAageXvokdtUyYU/8xtQDYUwvGuOXSQLAAo/j5h2sKcuPC++YmDEaHOwS9J7EbZX 35ZQ== X-Gm-Message-State: AOAM533KiOY5Qjv8j5WVVtclVSzI4Zt/GVB8CrfhvqMDsuRof44W9UA5 LZSg+Ly0Fj1pOkcK6H43+wRI8Q== X-Google-Smtp-Source: ABdhPJwrXY1wLIXcf7JPwbiSvbd/tSSquCR/9ybr4j/zHR05Jp4GC6jcA/TXr/MFpA24JNrnjlDRHw== X-Received: by 2002:a19:890b:: with SMTP id l11mr808529lfd.355.1601472657882; Wed, 30 Sep 2020 06:30:57 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id t5sm157267ljg.111.2020.09.30.06.30.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 06:30:57 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 4F1C4102BAF; Wed, 30 Sep 2020 16:30:55 +0300 (+03) Date: Wed, 30 Sep 2020 16:30:55 +0300 From: "Kirill A. Shutemov" To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Jason Gunthorpe , John Hubbard , Andrew Morton , Christoph Hellwig , Yang Shi , Oleg Nesterov , Kirill Tkhai , Hugh Dickins , Jann Horn , Linus Torvalds , Michal Hocko , Jan Kara , Andrea Arcangeli , Leon Romanovsky Subject: Re: [PATCH v2 2/4] mm/fork: Pass new vma pointer into copy_page_range() Message-ID: <20200930133055.sdejarcv7nyhc2yc@box> References: <20200925222600.6832-1-peterx@redhat.com> <20200925222600.6832-3-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925222600.6832-3-peterx@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 25, 2020 at 06:25:58PM -0400, Peter Xu wrote: > This prepares for the future work to trigger early cow on pinned pages during > fork(). No functional change intended. > > Signed-off-by: Peter Xu > --- > include/linux/mm.h | 2 +- > kernel/fork.c | 2 +- > mm/memory.c | 14 +++++++++----- > 3 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index b2f370f0b420..ae914be004b3 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1646,7 +1646,7 @@ struct mmu_notifier_range; > void free_pgd_range(struct mmu_gather *tlb, unsigned long addr, > unsigned long end, unsigned long floor, unsigned long ceiling); > int copy_page_range(struct mm_struct *dst, struct mm_struct *src, > - struct vm_area_struct *vma); > + struct vm_area_struct *vma, struct vm_area_struct *new); It makes dst/src mm_struct arguments redundant. There's always vma->vm_mm. -- Kirill A. Shutemov