From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43361C4727F for ; Tue, 29 Sep 2020 06:55:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B42CA20848 for ; Tue, 29 Sep 2020 06:55:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="eNJmfioA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B42CA20848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 14FA78E0001; Tue, 29 Sep 2020 02:55:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 100F76B005D; Tue, 29 Sep 2020 02:55:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2FD98E0001; Tue, 29 Sep 2020 02:55:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0241.hostedemail.com [216.40.44.241]) by kanga.kvack.org (Postfix) with ESMTP id D8E196B005C for ; Tue, 29 Sep 2020 02:55:10 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 947D2180AD801 for ; Tue, 29 Sep 2020 06:55:10 +0000 (UTC) X-FDA: 77315187180.29.angle06_0b078c827188 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 75594180868C0 for ; Tue, 29 Sep 2020 06:55:10 +0000 (UTC) X-HE-Tag: angle06_0b078c827188 X-Filterd-Recvd-Size: 3428 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 29 Sep 2020 06:55:09 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1601362508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kFYu5xJzDawvBAsBW8M/X+65x9wkUxCZnjOlwhAOe+4=; b=eNJmfioAPkH849P8Qsy/inkjnkjfDSoSN9X698/PQTJY+6RWqF191MR+5CLxKctgrcnYpc RdNepUo8VVKAgyob3/s/E7pWK+NFKkcLnE0cOJ5ahlvzzgrQHR9y3YoPHbnCEiwpKeXr72 QnX6AqmSNVrzbMBbZpYlUOPX9qYBk6Y= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 85EBCAA55; Tue, 29 Sep 2020 06:55:08 +0000 (UTC) Date: Tue, 29 Sep 2020 08:55:07 +0200 From: Michal Hocko To: Linus Torvalds Cc: Andrew Morton , cheloha@linux.ibm.com, David Hildenbrand , Fenghua Yu , Greg Kroah-Hartman , ldufour@linux.ibm.com, Linux-MM , mm-commits@vger.kernel.org, nathanl@linux.ibm.com, Oscar Salvador , Rafael Wysocki , stable , Tony Luck Subject: Re: [patch 8/9] mm: replace memmap_context by meminit_context Message-ID: <20200929065507.GA22035@dhcp22.suse.cz> References: <20200925211725.0fea54be9e9715486efea21f@linux-foundation.org> <20200926041928.9xJHGgkah%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat 26-09-20 10:32:15, Linus Torvalds wrote: > The explanations here do not make sense. > > On Fri, Sep 25, 2020 at 9:19 PM Andrew Morton wrote: > > > > > > There are 2 issues here: > > > > a. The sysfs memory and node's layouts are broken due to these multiple > > links > > > > b. The link errors in link_mem_sections() should not lead to a system > > panic. > > > > To address a. register_mem_sect_under_node should not rely on the system > > state to detect whether the link operation is triggered by a hot plug > > operation or not. This is addressed by the patches 1 and 2 of this series. > > > > The patch 3 is addressing the point b. > > > > This patch (of 2): > > > > The memmap_context enum is used to detect whether a memory operation is due > > to a hot-add operation or happening at boot time. > > > > Make it general to the hotplug operation and rename it as meminit_context. > > > > There is no functional change introduced by this patch > > So far so good. > > But there is no "patch 3" that addresses point (b) in this series. > > I see it on lore, but it's not part of what actually got sent to me, > so the commit message for patch 1 now makes no sense any more. You are right. There should be patch 2 posted as well. And I would argue that the 3rd patch should go in with them as well. This is a preparatory patch only. -- Michal Hocko SUSE Labs